Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create workflows to release Node.js adapter from own repo #520

Open
Tracked by #34862
mposolda opened this issue Dec 3, 2024 · 1 comment · May be fixed by #521
Open
Tracked by #34862

Create workflows to release Node.js adapter from own repo #520

mposolda opened this issue Dec 3, 2024 · 1 comment · May be fixed by #521
Assignees
@mposolda

Comments

@mposolda
Copy link
Contributor

mposolda commented Dec 3, 2024 •
edited
Loading

It can be good to have GH workflow, which will allow to release node.js from it's own repository .

NOTE (hint): It looks that there is already script release.sh, so perhaps that one is OK to be re-used in the workflow?
I guess this is used by the GH workflow, which is currently triggered from keycloak-rel during keycloak server release (We are going to remove releasing of node.js from keycloak-rel as we want to decouple node.js adapter release from keycloak-server release. Related task for decouple node.js release from keycloak-rel is keycloak/keycloak#35536 )
@mposolda mposolda mentioned this issue Dec 3, 2024
Open
@mposolda mposolda transferred this issue from keycloak/keycloak Dec 3, 2024
@mposolda mposolda mentioned this issue Dec 3, 2024
Open
@jonkoops
Copy link
Contributor

jonkoops commented Dec 3, 2024

I think the release.sh script is likely not used any longer and can be removed, the release is done from the workflow under keycloak-rel.

@mposolda mposolda self-assigned this Dec 6, 2024
@mposolda mposolda mentioned this issue Dec 9, 2024
Merged
mposolda added a commit to mposolda/keycloak-nodejs-connect that referenced this issue Dec 10, 2024
@mposolda
Create workflows to release Node.js adapter from own repo
10dc7df 
closes keycloak#520

Signed-off-by: mposolda <[email protected]>
@mposolda mposolda linked a pull request Dec 10, 2024 that will close this issue
Open
mposolda added a commit to mposolda/keycloak-nodejs-connect that referenced this issue Dec 13, 2024
@mposolda
Create workflows to release Node.js adapter from own repo
0a8a83e 
closes keycloak#520

Signed-off-by: mposolda <[email protected]>
mposolda added a commit to mposolda/keycloak-nodejs-connect that referenced this issue Dec 16, 2024
@mposolda
Create workflows to release Node.js adapter from own repo
dd78d69 
closes keycloak#520

Signed-off-by: mposolda <[email protected]>
mposolda added a commit to mposolda/keycloak-nodejs-connect that referenced this issue Dec 16, 2024
@mposolda @jonkoops
Create workflows to release Node.js adapter from own repo
9e81c9f 
closes keycloak#520

Signed-off-by: mposolda <[email protected]>

Co-authored-by: Jon Koops <[email protected]>
Signed-off-by: Marek Posolda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mposolda mposolda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create workflows to release Node.js adapter from own repo mposolda/keycloak-nodejs-connect
2 participants
@jonkoops @mposolda