Adding guides to keycloak-js #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
requested changes
Feb 5, 2025
Closes keycloak#31 Signed-off-by: rmartinc <[email protected]>
mposolda
reviewed
Feb 6, 2025
Co-authored-by: Marek Posolda <[email protected]> Signed-off-by: Jon Koops <[email protected]>
jonkoops
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
Just replicating what was done in the
keycloak-nodejs-connectproject:package.jsonis modified to addstandardandjszipas dev dependencies.eslintbut not in thelibfolder.npm run guidesagain.There is now a
package-lock.jsonbecause of the deps. I think that we are managing this in all the JS projects so I think that it's OK.