Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding modifiers to a custom key code doesn't show the modifier and allows it to be repeatedly added. #1320

Open
NabiYang opened this issue Jan 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@NabiYang
Copy link

NabiYang commented Jan 10, 2024

Describe the bug
If I use a custom key code, I can click a modifier toggle to add that modifier. It adds the correct number to the key code, but the toggle doesn't turn on. Because the toggle remains off, I can repeatedly click it and continue adding that amount.

To Reproduce

  1. Add the custom key code 102 to a key.
  2. Click the Shift toggle under Modifiers. It correctly adds 2048 for a total of 2150, but the toggle isn't activated.
  3. Click the Shift toggle again.
    ---> It adds another 2048 for a total now of 4198. This process can be repeated.

Expected behavior
I expect the toggle to turn on and disallow adding any more Shift to the key code.

Screenshots

Key Code 102 Added Shift Added Shift Again

Desktop (please complete the following information):

  • OS: Windows 11
  • Chrysalis Version: 0.13.3

Additional context
I imagine a solution might be to simply disallow adding modifiers into the custom key code, but this helped me to determine what key code was ultimately needed for a custom key code plus modifiers. It was useful.

@NabiYang NabiYang added the bug Something isn't working label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant