Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ical.timezones.js fails to parse timezones #510

Closed
kbalasub opened this issue May 20, 2022 · 2 comments
Closed

ical.timezones.js fails to parse timezones #510

kbalasub opened this issue May 20, 2022 · 2 comments

Comments

@kbalasub
Copy link

kbalasub commented May 20, 2022

Build ical.js from source using grunt package-zones. The load of ical.timezones.js throws an exception that it is unable to parse the timezones. This is because the line below

ICAL.TimezoneService.register(ICAL.Component.fromString("BEGIN:VTIMEZONE\r\n" + tzdata + "END:VTIMEZONE")) };

needs to be changed to

ICAL.TimezoneService.register(ICAL.Component.fromString("BEGIN:VTIMEZONE\r\n" + tzdata + "\r\nEND:VTIMEZONE")) };

@kbalasub kbalasub changed the title ical.timezone.js fails to parse timezones ical.timezones.js fails to parse timezones May 20, 2022
@kewisch kewisch closed this as completed in 3553349 Jun 9, 2023
@kewisch
Copy link
Owner

kewisch commented Jun 9, 2023

Thanks, taken care of in said commit!

@xeruf
Copy link

xeruf commented Nov 18, 2024

that seems very windows-y, sure that should not be the generic OS line separator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants