Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump download dependency #64

Closed
sebek64 opened this issue May 10, 2018 · 4 comments
Closed

Bump download dependency #64

sebek64 opened this issue May 10, 2018 · 4 comments

Comments

@sebek64
Copy link

sebek64 commented May 10, 2018

Current version doesn't honor strict-ssl option, causing a lot of trouble for users behind a proxy. For example, imagemin/optipng-bin#74. The fix is in 5 branch here kevva/download@559a6f5, but this project uses version 4.

@alexander-akait
Copy link

/cc @kevva it is possible to upgrade download to latest version? Also it is avoid security problem using npm audit

@coreyfarrell
Copy link

I just looked into upgrading to the latest download version. One test which downloads two tarballs and an uncompress JS file shows a change in behaviour. In download@4 the 'extract' option meant 'try to extract', for download@>=5 nothing is returned when the file is not compressed (no error or data is returned). I'm not sure if the solution is for download to fix it's handling of decompress so it returns the original file if it's not compressed, or if the test should be updated to expect non-compressed files to fail.

@jookshub
Copy link

As mentioned in the reference, due to node version restrictions with got there is a mismatch for the engines requirement >=6 should be >=6 <=7 or got needs to be updated.

@rejas
Copy link
Contributor

rejas commented Jul 13, 2018

PR for this bump is in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants