From c85b79e773b1a4dbcaf4a547fda9324d20581d25 Mon Sep 17 00:00:00 2001 From: Kevin Papst Date: Fri, 19 Jul 2024 22:16:06 +0200 Subject: [PATCH] make it simpler to increase max row and file size --- CHANGELOG.md | 6 ++++++ Form/ImportForm.php | 4 +++- Importer/ImporterService.php | 1 + composer.json | 2 +- 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 34daea6..dd68b28 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## Version 2.14.0 (unreleased) + +Compatibility: requires minimum Kimai 2.17.0 + +- Make it simpler to increase max row and file size + ## Version 2.13.0 Compatibility: requires minimum Kimai 2.17.0 diff --git a/Form/ImportForm.php b/Form/ImportForm.php index 7f03fc9..740b947 100644 --- a/Form/ImportForm.php +++ b/Form/ImportForm.php @@ -10,6 +10,7 @@ namespace KimaiPlugin\ImportBundle\Form; +use KimaiPlugin\ImportBundle\Importer\ImporterService; use KimaiPlugin\ImportBundle\Model\ImportModel; use Symfony\Component\Form\AbstractType; use Symfony\Component\Form\Extension\Core\Type\CheckboxType; @@ -49,7 +50,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void 'constraints' => [ new NotNull(), new File([ - 'maxSize' => '1024k', + 'maxSize' => $options['max_file_size'], ]) ], ]) @@ -64,6 +65,7 @@ public function configureOptions(OptionsResolver $resolver): void 'csrf_field_name' => '_token', 'csrf_token_id' => 'import_csv_data', 'method' => 'POST', + 'max_file_size' => ImporterService::MAX_FILESIZE, ]); } } diff --git a/Importer/ImporterService.php b/Importer/ImporterService.php index b1904b5..a7dfdcd 100644 --- a/Importer/ImporterService.php +++ b/Importer/ImporterService.php @@ -21,6 +21,7 @@ final class ImporterService { public const MAX_ROWS = 1000; + public const MAX_FILESIZE = '1024k'; /** * @param iterable $importer diff --git a/composer.json b/composer.json index 6320be7..0559a70 100644 --- a/composer.json +++ b/composer.json @@ -3,7 +3,7 @@ "description": "Import data from CSV files via Web UI", "homepage": "https://www.kimai.org/store/keleo-importer-bundle.html", "type": "kimai-plugin", - "version": "2.13.0", + "version": "2.14.0", "keywords": [ "kimai", "kimai-plugin"