Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10" Tablet devices reported as mobile, looking for advice #19

Open
thuss opened this issue May 25, 2012 · 3 comments
Open

10" Tablet devices reported as mobile, looking for advice #19

thuss opened this issue May 25, 2012 · 3 comments

Comments

@thuss
Copy link
Contributor

thuss commented May 25, 2012

Thanks for the great work on agent_orange!

We're using it to detect mobile UA's on http://www.classmonkeys.com to serve users a mobile experience. The only issue we've run into is that 10" tablets which fall in the gray area between mobile phone and laptop (which we want to serve a desktop web experience to) are reported as mobile.

Is there some way we haven't thought of using agent orange to see if something is a tablet?

@kevinelliott
Copy link
Owner

Great question. I do think it would be good to identify tablets as tablets. I'll put some thought into this and implement a refactor. I'm glad you're finding agent_orange useful.

-Kevin

On May 25, 2012, at 1:40 PM, Todd Huss wrote:

Thanks for the great work on agent_orange!

We're using it to detect mobile UA's on http://www.classmonkeys.com to serve users a mobile experience. The only issue we've run into is that 10" tablets which fall in the gray area between mobile phone and laptop (which we want to serve a desktop web experience to) are reported as mobile.

Is there some way we haven't thought of using agent orange to see if something is a tablet?


Reply to this email directly or view it on GitHub:
#19

@rjacoby
Copy link

rjacoby commented Nov 30, 2012

One case is the Samsung Galaxy Tab II, which Facebook treats as a mobile but does not broadcast a string that your regex would match.

Its agent we match for that case is 'GT-P3113'.

@kevinelliott
Copy link
Owner

This brings up an interesting issue. We should probably have an exceptions list that contains a specific regex and avoids the parsing chain, allowing you to set specific details. It might also be nice to add in the ability to easily add exceptions via config in your app so that the gem doesn't need to be modified to implement quick changes.

On Nov 30, 2012, at 8:39 AM, Rafi Jacoby [email protected] wrote:

One case is the Samsung Galaxy Tab II, which Facebook treats as a mobile but does not broadcast a string that your regex would match.

Its agent we match for that case is 'GT-P3113'.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants