Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to add a new bot #14

Open
scottillogical opened this issue Apr 12, 2012 · 2 comments
Open

Trying to add a new bot #14

scottillogical opened this issue Apr 12, 2012 · 2 comments
Assignees

Comments

@scottillogical
Copy link

I have a simple spec

ua =  AgentOrange::UserAgent.new("Pingdom.com_bot_version_1.4_(http://www.pingdom.com/)" )
ua.is_bot?.should eql true

It returns false

I added

id_new_190610_333333 Pingdom.com_bot_version_1.4_(http://www.pingdom.com/) Pingdom bot R http://www.pingdom.com

To the end of the xml but it's still not correctly marking this as a bot.

What is the deal with the xml, how do I add a new bot to the list?

@kevinelliott
Copy link
Owner

Adding the details to the xml will only add it to the tests to check the parser against. In order to add support for this bot, it must be added to the library itself. I will look into this shortly.

@kevinelliott
Copy link
Owner

Try again with the improved bot detection. Let me know how things work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants