Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Straighten trace using more sophisticated techniques #674

Open
1 task done
kevin218 opened this issue Aug 1, 2024 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request NIRSpec

Comments

@kevin218
Copy link
Owner

kevin218 commented Aug 1, 2024

Instrument

NIRSpec (Stages 1-3)

What is your suggestion?

In straighten.find_column_median_shifts(), we currently apply a center of mass calculation to determine the position of the trace in each column. This works well for most cases, but there are instances where it doesn't when using a calibrated NIRSpec grism spectrum (particularly for NRS2). We should consider adding other centroiding options, like max pixel, that are more robust against outliers.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kevin218 kevin218 added the enhancement New feature or request label Aug 1, 2024
@kevin218 kevin218 self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NIRSpec
Projects
None yet
Development

No branches or pull requests

2 participants