Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Change photometry reduction code to run like spectroscopy code #514

Open
1 task done
taylorbell57 opened this issue Apr 3, 2023 · 0 comments · May be fixed by #729
Open
1 task done

[Enhancement]: Change photometry reduction code to run like spectroscopy code #514

taylorbell57 opened this issue Apr 3, 2023 · 0 comments · May be fixed by #729
Assignees
@taylorbell57
Labels
enhancement New feature or request MIRI NIRCam

Comments

@taylorbell57
Copy link
Collaborator

taylorbell57 commented Apr 3, 2023 •
edited
Loading

Instrument

NIRCam (Stages 1-3), MIRI (Stages 1-3)

What is your suggestion?

At present, the photometry code works one integration at a time, performing all the processing steps on each integration and then continuing on to the next integration. This really limits the extent to which the code can be parallelized. My intern or I will seek to reorganize the photometry code to run in the same fasion as the spectroscopy code, running each processing step on all the integrations and then continuing on to the next processing step.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@taylorbell57 taylorbell57 added the enhancement New feature or request label Apr 3, 2023
@taylorbell57 taylorbell57 self-assigned this Apr 3, 2023
@kevin218 kevin218 moved this to To do in Road to v2.0 Jul 26, 2024
taylorbell57 added a commit that referenced this issue Dec 18, 2024
@taylorbell57
Chainging S3 photometry to run like spectroscopy
0307631 
Resolves #514

Photometry will now run each step for all integrations before moving on to the next step. This makes parallelizing easier and makes some steps easier.
@taylorbell57 taylorbell57 linked a pull request Dec 18, 2024 that will close this issue
Open
8 tasks
@taylorbell57 taylorbell57 moved this from To do to In progress in Performance improvement Dec 18, 2024
@taylorbell57 taylorbell57 moved this from To do to In progress in Road to v2.0 Dec 18, 2024
@taylorbell57 taylorbell57 moved this from To Do to In Progress in Stage 3: Data Reduction Dec 18, 2024
@taylorbell57 taylorbell57 moved this from To do to In progress in Allow Imaging Observations Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylorbell57 taylorbell57

Labels
enhancement New feature or request MIRI NIRCam
Projects
Allow Imaging Observations
Status: In progress
Performance improvement
Status: In progress
Road to v2.0
Status: In progress
Stage 3: Data Reduction
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding optimal photometric extraction and photutils aperture extraction kevin218/Eureka
4 participants
@kevin218 @taylorbell57 @meganmansfield @sebastian-zieba