From f7d2a8cd52ca2e88072e177f971c3bc85d842903 Mon Sep 17 00:00:00 2001 From: David Jacot Date: Fri, 8 Nov 2024 17:00:03 +0100 Subject: [PATCH] MINOR: Cleanup GroupCoordinatorRecordHelpers (#17718) Reviewers: Jeff Kim , Mickael Maison , Chia-Ping Tsai --- .../group/GroupCoordinatorRecordHelpers.java | 35 ++----------------- 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java index be912107504eb..b3aa3b9db77fb 100644 --- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java +++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java @@ -360,35 +360,6 @@ public static CoordinatorRecord newConsumerGroupCurrentAssignmentRecord( ); } - /** - * Creates a ConsumerGroupCurrentMemberAssignment record. - * - * @param groupId The consumer group id. - * @param member The share group member. - * @return The record. - */ - public static CoordinatorRecord newConsumerGroupCurrentAssignmentRecord( - String groupId, - ShareGroupMember member - ) { - return new CoordinatorRecord( - new ApiMessageAndVersion( - new ConsumerGroupCurrentMemberAssignmentKey() - .setGroupId(groupId) - .setMemberId(member.memberId()), - (short) 8 - ), - new ApiMessageAndVersion( - new ConsumerGroupCurrentMemberAssignmentValue() - .setMemberEpoch(member.memberEpoch()) - .setPreviousMemberEpoch(member.previousMemberEpoch()) - .setState(member.state().value()) - .setAssignedPartitions(toTopicPartitions(member.assignedPartitions())), - (short) 0 - ) - ); - } - /** * Creates a ConsumerGroupCurrentMemberAssignment tombstone. * @@ -731,7 +702,7 @@ public static CoordinatorRecord newShareGroupSubscriptionMetadataRecord( * @return The record. */ public static CoordinatorRecord newShareGroupSubscriptionMetadataTombstoneRecord( - String groupId + String groupId ) { return new CoordinatorRecord( new ApiMessageAndVersion( @@ -929,8 +900,8 @@ public static CoordinatorRecord newShareGroupCurrentAssignmentRecord( * @return The record. */ public static CoordinatorRecord newShareGroupCurrentAssignmentTombstoneRecord( - String groupId, - String memberId + String groupId, + String memberId ) { return new CoordinatorRecord( new ApiMessageAndVersion(