Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in src/pfcurlprocessing.php for PHP7 compatibility #39

Open
jhf2442 opened this issue Jun 30, 2016 · 5 comments
Open

Fix in src/pfcurlprocessing.php for PHP7 compatibility #39

jhf2442 opened this issue Jun 30, 2016 · 5 comments

Comments

@jhf2442
Copy link

jhf2442 commented Jun 30, 2016

(sorry for not submitting a pull request, can't get it done - don't know what I'm doing wrong :-( )
pfcurlprocessing.php in PHP7 (Ubuntu 16.04) causes empty message content displayed

issue is caused by deprecated /e modifier in preg_replace. Fix is to go for preg_replace_callback

The 3 preg_replace statements must thus read :
$ret = preg_replace_callback("#(^|[\n ]])([\w]+?://[\w#$%()&~/!.-;:=,?@+]*)#is", function($m) { return "$m[1]<a href="$m[2]"" . $target . ">" . pfc_shorten_url($m[2]) . "";}, $ret);

$ret = preg_replace_callback("#(^|[\n ]])((www|ftp).[\w#$%&~/.-;:=,?@+]*)#is",function($m) { return "$m[1]<a href="http://$m[2]"" . $target . ">" . pfc_shorten_url($m[2]) . "";}, $ret);

$ret = preg_replace_callback("#(^|[\n ]])([a-z0-9&-_.]+?)@([\w-]+.([\w-.]+.)*[\w]+)#i", function($m) { return "$m[1]<a href="mailto:$m[2]@$m[3]">" . pfc_shorten_url($m[2].'@'.$m[3]) . "";}, $ret);

@EZWrighter
Copy link

attempted this change and still getting blank messages :-( Currently just removed the pfc_make_hyperlink call from the get message command and things all work except the auto hyperlinking.

@webprogrammierer
Copy link

I solved it like this (for PHP 7):

$ret = preg_replace_callback("#(^|[\n \]])([\w]+?://[\w\#$%\(\)&~/!.\-;:=,?@+]*)#is", 'replace_callback_1', $ret);
$ret = preg_replace_callback("#(^|[\n \]])((www|ftp)\.[\w\#$%&~/.\-;:=,?@+]*)#is", 'replace_callback_2', $ret);  
$ret = preg_replace_callback("#(^|[\n \]])([a-z0-9&\-_.]+?)@([\w\-]+\.([\w\-\.]+\.)*[\w]+)#i", 'replace_callback_3', $ret); 

function replace_callback_1($matches) {
  $target = " onclick=\"window.open(this.href,'_blank');return false;\"";
  return $matches[1].'<a href="'.$matches[2].'"' . $target . '>' . pfc_shorten_url($matches[2]) . '</a>';
}  
function replace_callback_2($matches) {
  $target = " onclick=\"window.open(this.href,'_blank');return false;\"";
  return $matches[1].'<a href="http://'.$matches[2].'"' . $target . '>' . pfc_shorten_url($matches[2]) . '</a>';
}  
function replace_callback_3($matches) {
  return $matches[1].'<a href="mailto:'.$matches[2].'@'.$matches[3].'">' . pfc_shorten_url($matches[2].'@'.$matches[3]) . '</a>';
}

@Torsten-K
Copy link

@webprogrammierer Which file do I have to put this code into?

@webprogrammierer
Copy link

@Torsten-K I have made this changes in the file src/pfcurlprocessing.php

@Torsten-K
Copy link

@webprogrammierer Danke schön / thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants