Rewrite generate() to make pylint happy (less branches)

Signed-off-by: Denys Fedoryshchenko <[email protected]>

Author: nuclearcat

kernelci/cli/__init__.py

@@ -92,7 +92,7 @@ def call(*args, **kwargs):
         except KeyError as ex:
             traceback.print_exc()
             raise click.ClickException(
-                f"KernelCI Error: Value not found for {str(ex)}") from ex
+                f"Key Error: Value not found for {str(ex)}") from ex
     return call
 
 

kernelci/cli/job.py

@@ -108,17 +108,7 @@ def generate(node_id,  # pylint: disable=too-many-arguments, too-many-locals
         configs['storage'][storage]
         if storage else None
     )
-    if not runtime:
-        raise click.ClickException("No runtime provided (--runtime)")
-    runtimes_section = configs.get('runtimes', None)
-    if runtimes_section is None:
-        raise click.ClickException("No runtimes section found in the config")
-    runtime_config = runtimes_section.get(runtime, None)
-    if runtime_config is None:
-        raise click.ClickException(f"Runtime {runtime} not found in the config")
-    runtime = kernelci.runtime.get_runtime(
-        runtime_config, token=secrets.api.runtime_token,
-        custom_template_dir=config[0] if config else None)
+    runtime = _get_runtime(runtime, config, secrets)
     params = runtime.get_params(job, api.config)
     if not params:
         raise click.ClickException("Invalid job parameters, aborting...")
@@ -138,6 +128,16 @@ def generate(node_id,  # pylint: disable=too-many-arguments, too-many-locals
         click.echo(job_data)
 
 
+def _get_runtime(runtime, config, secrets):
+    configs = kernelci.config.load(config)
+    runtime_config = configs['runtimes'][runtime]
+    runtime = kernelci.runtime.get_runtime(
+        runtime_config, token=secrets.api.runtime_token,
+        custom_template_dir=config[0] if config else None
+    )
+    return runtime
+
+
 @kci_job.command(secrets=True)
 @click.argument('job-path')
 @click.option('--wait', is_flag=True)

kernelci/config/__init__.py

@@ -38,6 +38,7 @@ def get_config_paths(config_paths):
         for config_path in ['config/core', '/etc/kernelci/core']:
             if os.path.isdir(config_path):
                 config_paths.append(config_path)
+                break
     elif isinstance(config_paths, str):
         config_paths = [config_paths]
     return config_paths