Feat: add platforms to hardware column #859
Open
+215
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
force-pushed
the
feat/add-platforms-to-hardware-column
branch
2 times, most recently
from
8e11ebb to
d59981a
Compare
Added enviroment_misc.platform as a fallback case for the hardware column. When environment_compatible is null/undefined it will use the platform of the test if available Part of #854
Added enviroment_misc.platform as a fallback case for the hardware
column. When environment_compatible is null/undefined it will use the
platform of the test if available
Closes #854
murilx
force-pushed
the
feat/add-platforms-to-hardware-column
branch
from
d59981a to
589e34d
Compare
WilsonNet
reviewed
Jan 30, 2025
Comment on lines
+9
to
+11
| : misc?.platform | ||
| ? [misc?.platform] | ||
| : undefined; |
There was a problem hiding this comment.
this is pretty much the same as misc?.platform
There was a problem hiding this comment.
misc?.platform is type string | undefined and I need the result to be string[] | undefined. Doing only [misc?.platform], wouldn't work as well because that would be type (string | undefined)[]
WilsonNet
reviewed
Jan 30, 2025
| ]; | ||
| import { buildHardwareArray } from '@/utils/table'; | ||
|
|
||
| import { defaultColumns } from './DefaultBootsColumns'; |
There was a problem hiding this comment.
there is pretty much no gain moving to another file it will be only used in a single place
There was a problem hiding this comment.
I was following the same structure that was done to TestsTable but it makes sense, I'll change it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
environment_misc.platformas a fallback to hardware whenenvironment_compatibleis fullCloses #854
Important: In the current form boots table is showing the hardware column in the hardware details page but tests table is not. Should hardware column be added to the tests table, should it be removed from the boots table or should I keep it like it is already?