Skip to content

Commit deeb5bf

Browse files
author
Kernel Patches Daemon
committed
adding ci files
1 parent a36a835 commit deeb5bf

File tree

54 files changed

+4356
-18
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+4356
-18
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
name: 'run-veristat'
2+
description: 'Run veristat benchmark'
3+
inputs:
4+
veristat_output:
5+
description: 'Veristat output filepath'
6+
required: true
7+
baseline_name:
8+
description: 'Veristat baseline cache name'
9+
required: true
10+
runs:
11+
using: "composite"
12+
steps:
13+
- uses: actions/upload-artifact@v4
14+
with:
15+
name: ${{ inputs.baseline_name }}
16+
if-no-files-found: error
17+
path: ${{ github.workspace }}/${{ inputs.veristat_output }}
18+
19+
# For pull request:
20+
# - get baseline log from cache
21+
# - compare it to current run
22+
- if: ${{ github.event_name == 'pull_request' }}
23+
uses: actions/cache/restore@v4
24+
with:
25+
key: ${{ inputs.baseline_name }}
26+
restore-keys: |
27+
${{ inputs.baseline_name }}-
28+
path: '${{ github.workspace }}/${{ inputs.baseline_name }}'
29+
30+
- if: ${{ github.event_name == 'pull_request' }}
31+
name: Show veristat comparison
32+
shell: bash
33+
run: ./.github/scripts/compare-veristat-results.sh
34+
env:
35+
BASELINE_PATH: ${{ github.workspace }}/${{ inputs.baseline_name }}
36+
VERISTAT_OUTPUT: ${{ inputs.veristat_output }}
37+
38+
# For push: just put baseline log to cache
39+
- if: ${{ github.event_name == 'push' }}
40+
shell: bash
41+
run: |
42+
mv "${{ github.workspace }}/${{ inputs.veristat_output }}" \
43+
"${{ github.workspace }}/${{ inputs.baseline_name }}"
44+
45+
- if: ${{ github.event_name == 'push' }}
46+
uses: actions/cache/save@v4
47+
with:
48+
key: ${{ inputs.baseline_name }}-${{ github.run_id }}
49+
path: '${{ github.workspace }}/${{ inputs.baseline_name }}'
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
#!/bin/bash
2+
3+
if [[ ! -f "${BASELINE_PATH}" ]]; then
4+
echo "# No ${BASELINE_PATH} available" >> "${GITHUB_STEP_SUMMARY}"
5+
6+
echo "No ${BASELINE_PATH} available"
7+
echo "Printing veristat results"
8+
cat "${VERISTAT_OUTPUT}"
9+
10+
exit
11+
fi
12+
13+
selftests/bpf/veristat \
14+
--output-format csv \
15+
--emit file,prog,verdict,states \
16+
--compare "${BASELINE_PATH}" "${VERISTAT_OUTPUT}" > compare.csv
17+
18+
python3 ./.github/scripts/veristat_compare.py compare.csv

.github/scripts/matrix.py

+202
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,202 @@
1+
#!/usr/bin/env python3
2+
3+
import os
4+
import dataclasses
5+
import json
6+
7+
from enum import Enum
8+
from typing import Any, Dict, List, Final, Set, Union
9+
10+
MANAGED_OWNER: Final[str] = "kernel-patches"
11+
MANAGED_REPOS: Final[Set[str]] = {
12+
f"{MANAGED_OWNER}/bpf",
13+
f"{MANAGED_OWNER}/vmtest",
14+
}
15+
16+
DEFAULT_RUNNER: Final[str] = "ubuntu-24.04"
17+
DEFAULT_LLVM_VERSION: Final[int] = 17
18+
DEFAULT_SELF_HOSTED_RUNNER_TAGS: Final[List[str]] = ["self-hosted", "docker-noble-main"]
19+
20+
21+
class Arch(str, Enum):
22+
"""
23+
CPU architecture supported by CI.
24+
"""
25+
26+
AARCH64 = "aarch64"
27+
S390X = "s390x"
28+
X86_64 = "x86_64"
29+
30+
31+
class Compiler(str, Enum):
32+
GCC = "gcc"
33+
LLVM = "llvm"
34+
35+
36+
@dataclasses.dataclass
37+
class Toolchain:
38+
compiler: Compiler
39+
# This is relevant ONLY for LLVM and should not be required for GCC
40+
version: int
41+
42+
@property
43+
def short_name(self) -> str:
44+
return str(self.compiler.value)
45+
46+
@property
47+
def full_name(self) -> str:
48+
if self.compiler == Compiler.GCC:
49+
return self.short_name
50+
51+
return f"{self.short_name}-{self.version}"
52+
53+
def to_dict(self) -> Dict[str, Union[str, int]]:
54+
return {
55+
"name": self.short_name,
56+
"fullname": self.full_name,
57+
"version": self.version,
58+
}
59+
60+
61+
@dataclasses.dataclass
62+
class BuildConfig:
63+
arch: Arch
64+
toolchain: Toolchain
65+
kernel: str = "LATEST"
66+
run_veristat: bool = False
67+
parallel_tests: bool = False
68+
build_release: bool = False
69+
70+
@property
71+
def runs_on(self) -> List[str]:
72+
if is_managed_repo():
73+
return DEFAULT_SELF_HOSTED_RUNNER_TAGS + [self.arch.value]
74+
return [DEFAULT_RUNNER]
75+
76+
@property
77+
def build_runs_on(self) -> List[str]:
78+
if is_managed_repo():
79+
# Build s390x on x86_64
80+
return DEFAULT_SELF_HOSTED_RUNNER_TAGS + [
81+
self.arch.value == "s390x" and Arch.X86_64.value or self.arch.value,
82+
]
83+
return [DEFAULT_RUNNER]
84+
85+
@property
86+
def tests(self) -> Dict[str, Any]:
87+
tests_list = [
88+
"test_progs",
89+
"test_progs_parallel",
90+
"test_progs_no_alu32",
91+
"test_progs_no_alu32_parallel",
92+
"test_verifier",
93+
]
94+
95+
if self.arch.value != "s390x":
96+
tests_list.append("test_maps")
97+
98+
if self.toolchain.version >= 18:
99+
tests_list.append("test_progs_cpuv4")
100+
101+
# if self.arch in [Arch.X86_64, Arch.AARCH64]:
102+
# tests_list.append("sched_ext")
103+
104+
# Don't run GCC BPF runner, because too many tests are failing
105+
# See: https://lore.kernel.org/bpf/[email protected]/
106+
# if self.arch == Arch.X86_64:
107+
# tests_list.append("test_progs-bpf_gcc")
108+
109+
if not self.parallel_tests:
110+
tests_list = [test for test in tests_list if not test.endswith("parallel")]
111+
112+
return {"include": [generate_test_config(test) for test in tests_list]}
113+
114+
def to_dict(self) -> Dict[str, Any]:
115+
return {
116+
"arch": self.arch.value,
117+
"toolchain": self.toolchain.to_dict(),
118+
"kernel": self.kernel,
119+
"run_veristat": self.run_veristat,
120+
"parallel_tests": self.parallel_tests,
121+
"build_release": self.build_release,
122+
"runs_on": self.runs_on,
123+
"tests": self.tests,
124+
"build_runs_on": self.build_runs_on,
125+
}
126+
127+
128+
def is_managed_repo() -> bool:
129+
return (
130+
os.environ["GITHUB_REPOSITORY_OWNER"] == MANAGED_OWNER
131+
and os.environ["GITHUB_REPOSITORY"] in MANAGED_REPOS
132+
)
133+
134+
135+
def set_output(name, value):
136+
"""Write an output variable to the GitHub output file."""
137+
with open(os.getenv("GITHUB_OUTPUT"), "a", encoding="utf-8") as file:
138+
file.write(f"{name}={value}\n")
139+
140+
141+
def generate_test_config(test: str) -> Dict[str, Union[str, int]]:
142+
"""Create the configuration for the provided test."""
143+
is_parallel = test.endswith("_parallel")
144+
config = {
145+
"test": test,
146+
"continue_on_error": is_parallel,
147+
# While in experimental mode, parallel jobs may get stuck
148+
# anywhere, including in user space where the kernel won't detect
149+
# a problem and panic. We add a second layer of (smaller) timeouts
150+
# here such that if we get stuck in a parallel run, we hit this
151+
# timeout and fail without affecting the overall job success (as
152+
# would be the case if we hit the job-wide timeout). For
153+
# non-experimental jobs, 360 is the default which will be
154+
# superseded by the overall workflow timeout (but we need to
155+
# specify something).
156+
"timeout_minutes": 30 if is_parallel else 360,
157+
}
158+
return config
159+
160+
161+
if __name__ == "__main__":
162+
matrix = [
163+
BuildConfig(
164+
arch=Arch.X86_64,
165+
toolchain=Toolchain(compiler=Compiler.GCC, version=DEFAULT_LLVM_VERSION),
166+
run_veristat=True,
167+
parallel_tests=True,
168+
),
169+
BuildConfig(
170+
arch=Arch.X86_64,
171+
toolchain=Toolchain(compiler=Compiler.LLVM, version=DEFAULT_LLVM_VERSION),
172+
build_release=True,
173+
),
174+
BuildConfig(
175+
arch=Arch.X86_64,
176+
toolchain=Toolchain(compiler=Compiler.LLVM, version=18),
177+
build_release=True,
178+
),
179+
BuildConfig(
180+
arch=Arch.AARCH64,
181+
toolchain=Toolchain(compiler=Compiler.GCC, version=DEFAULT_LLVM_VERSION),
182+
),
183+
# BuildConfig(
184+
# arch=Arch.AARCH64,
185+
# toolchain=Toolchain(
186+
# compiler=Compiler.LLVM,
187+
# version=DEFAULT_LLVM_VERSION
188+
# ),
189+
# ),
190+
BuildConfig(
191+
arch=Arch.S390X,
192+
toolchain=Toolchain(compiler=Compiler.GCC, version=DEFAULT_LLVM_VERSION),
193+
),
194+
]
195+
196+
# Outside of those repositories we only run on x86_64
197+
if not is_managed_repo():
198+
matrix = [config for config in matrix if config.arch == Arch.X86_64]
199+
200+
json_matrix = json.dumps({"include": [config.to_dict() for config in matrix]})
201+
print(json_matrix)
202+
set_output("build_matrix", json_matrix)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
#!/usr/bin/env python3
2+
3+
import unittest
4+
from typing import Iterable, List
5+
6+
from ..veristat_compare import parse_table, VeristatFields
7+
8+
9+
def gen_csv_table(records: Iterable[str]) -> List[str]:
10+
return [
11+
",".join(VeristatFields.headers()),
12+
*records,
13+
]
14+
15+
16+
class TestVeristatCompare(unittest.TestCase):
17+
def test_parse_table_ignore_new_prog(self):
18+
table = gen_csv_table(
19+
[
20+
"prog_file.bpf.o,prog_name,N/A,success,N/A,N/A,1,N/A",
21+
]
22+
)
23+
veristat_info = parse_table(table)
24+
self.assertEqual(veristat_info.table, [])
25+
self.assertFalse(veristat_info.changes)
26+
self.assertFalse(veristat_info.new_failures)
27+
28+
def test_parse_table_ignore_removed_prog(self):
29+
table = gen_csv_table(
30+
[
31+
"prog_file.bpf.o,prog_name,success,N/A,N/A,1,N/A,N/A",
32+
]
33+
)
34+
veristat_info = parse_table(table)
35+
self.assertEqual(veristat_info.table, [])
36+
self.assertFalse(veristat_info.changes)
37+
self.assertFalse(veristat_info.new_failures)
38+
39+
def test_parse_table_new_failure(self):
40+
table = gen_csv_table(
41+
[
42+
"prog_file.bpf.o,prog_name,success,failure,MISMATCH,1,1,+0 (+0.00%)",
43+
]
44+
)
45+
veristat_info = parse_table(table)
46+
self.assertEqual(
47+
veristat_info.table,
48+
[["prog_file.bpf.o", "prog_name", "success -> failure (!!)", "+0.00 %"]],
49+
)
50+
self.assertTrue(veristat_info.changes)
51+
self.assertTrue(veristat_info.new_failures)
52+
53+
def test_parse_table_new_changes(self):
54+
table = gen_csv_table(
55+
[
56+
"prog_file.bpf.o,prog_name,failure,success,MISMATCH,0,0,+0 (+0.00%)",
57+
"prog_file.bpf.o,prog_name_increase,failure,failure,MATCH,1,2,+1 (+100.00%)",
58+
"prog_file.bpf.o,prog_name_decrease,success,success,MATCH,1,1,-1 (-100.00%)",
59+
]
60+
)
61+
veristat_info = parse_table(table)
62+
self.assertEqual(
63+
veristat_info.table,
64+
[
65+
["prog_file.bpf.o", "prog_name", "failure -> success", "+0.00 %"],
66+
["prog_file.bpf.o", "prog_name_increase", "failure", "+100.00 %"],
67+
["prog_file.bpf.o", "prog_name_decrease", "success", "-100.00 %"],
68+
],
69+
)
70+
self.assertTrue(veristat_info.changes)
71+
self.assertFalse(veristat_info.new_failures)
72+
73+
74+
if __name__ == "__main__":
75+
unittest.main()

0 commit comments

Comments
 (0)