Skip to content

Commit 5abde62

Browse files
hormsborkmann
authored andcommitted
bpf: Avoid unnecessary use of comma operator in verifier
Although it does not seem to have any untoward side-effects, the use of ';' to separate to assignments seems more appropriate than ','. Flagged by clang-17 -Wcomma No functional change intended. Compile tested only. Signed-off-by: Simon Horman <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Reviewed-by: Dave Marchevsky <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
1 parent b08c8fc commit 5abde62

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/bpf/verifier.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -9616,7 +9616,7 @@ static int set_find_vma_callback_state(struct bpf_verifier_env *env,
96169616
callee->regs[BPF_REG_2].type = PTR_TO_BTF_ID;
96179617
__mark_reg_known_zero(&callee->regs[BPF_REG_2]);
96189618
callee->regs[BPF_REG_2].btf = btf_vmlinux;
9619-
callee->regs[BPF_REG_2].btf_id = btf_tracing_ids[BTF_TRACING_TYPE_VMA],
9619+
callee->regs[BPF_REG_2].btf_id = btf_tracing_ids[BTF_TRACING_TYPE_VMA];
96209620

96219621
/* pointer to stack or null */
96229622
callee->regs[BPF_REG_3] = caller->regs[BPF_REG_4];

0 commit comments

Comments
 (0)