Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make smile-ml models fully portable #91

Closed
kermitt2 opened this issue Nov 2, 2018 · 1 comment
Closed

Make smile-ml models fully portable #91

kermitt2 opened this issue Nov 2, 2018 · 1 comment

Comments

@kermitt2
Copy link
Owner

kermitt2 commented Nov 2, 2018

Current serialization of the smile-ml models appears to depend on the locale, raising some performance issues (surprisingly they are parsed, but can hang badly when predicting).

We should review the current method used for serializing the models which is xstream or force the Locale to be used by xstream when loading a saved model.
@kermitt2
Copy link
Owner Author

This looks all good and portable currently, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kermitt2