From 62656685254a06a57d4854a6bffed6d553ac3bb1 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 11:29:58 +0300 Subject: [PATCH 01/17] Update HELP.md --- HELP.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/HELP.md b/HELP.md index 18ff954..6e29f8e 100644 --- a/HELP.md +++ b/HELP.md @@ -1,3 +1,13 @@ +======= + +### First Install + +First use? you need to watch this ([gif](http://g.recordit.co/fuMlPcmSCI.gif)) + +![demo][install-image] + +[install-image]: http://g.recordit.co/fuMlPcmSCI.gif + If you don't see any icons, please make sure you have installed your icon fonts. ======= From 6c654d7fbb7863e9002851cea49dd4e83d893363 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 11:33:02 +0300 Subject: [PATCH 02/17] Update README.md --- README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 003b79a..476a39a 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,13 @@ [![Latest Version](https://img.shields.io/github/release/keremciu/sketch-iconfont.svg?style=flat-square)](https://github.com/keremciu/sketch-iconfont/releases) [![Join the chat at https://gitter.im/keremciu/sketch-iconfont](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/keremciu/sketch-iconfont?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) -### New Feature - 29 April 2016 +### New Features and Fixes - 17 August 2016 + +Hey guys, I've fixed the problem with 3.91 version of Sketch. + +Also we've new features like multiple text change, I will share gifs about them soon. Before sharing gifs, you can find and use them :) + +### New Feature - Convert Command - 29 April 2016 ![demo][demo-image] Your teammates don't have your icon-fonts? don't worry now you can convert all icons with one command then share it. From b5c4d944afb5273f968ea39290da808066d82c8f Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 12:07:22 +0300 Subject: [PATCH 03/17] Update HELP.md --- HELP.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/HELP.md b/HELP.md index 6e29f8e..2c73e35 100644 --- a/HELP.md +++ b/HELP.md @@ -2,11 +2,11 @@ ### First Install -First use? you need to watch this ([gif](http://g.recordit.co/fuMlPcmSCI.gif)) +First use? you need to watch this ([gif](http://g.recordit.co/2PMTB04Jav.gif)) ![demo][install-image] -[install-image]: http://g.recordit.co/fuMlPcmSCI.gif +[install-image]: http://g.recordit.co/2PMTB04Jav.gif If you don't see any icons, please make sure you have installed your icon fonts. From 77e9d592b98b19d32951da3d2e44e7d6a626bfa1 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 12:08:17 +0300 Subject: [PATCH 04/17] Update README.md --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index 476a39a..ff65790 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,14 @@ Hey guys, I've fixed the problem with 3.91 version of Sketch. Also we've new features like multiple text change, I will share gifs about them soon. Before sharing gifs, you can find and use them :) +### First Install + +First use? you need to watch this ([gif](http://g.recordit.co/2PMTB04Jav.gif)) + +![demo][install-image] + +[install-image]: http://g.recordit.co/2PMTB04Jav.gif + ### New Feature - Convert Command - 29 April 2016 ![demo][demo-image] From 5b28608eb8383f7b269f7838dcccbd33b57867ca Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 12:10:57 +0300 Subject: [PATCH 05/17] Update README.md --- README.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index ff65790..ff6aa40 100644 --- a/README.md +++ b/README.md @@ -9,11 +9,9 @@ Also we've new features like multiple text change, I will share gifs about them ### First Install -First use? you need to watch this ([gif](http://g.recordit.co/2PMTB04Jav.gif)) +First use? you need to watch ([THIS GIF](http://g.recordit.co/2PMTB04Jav.gif)) +##### Please if you have an issue, first watch the gif. -![demo][install-image] - -[install-image]: http://g.recordit.co/2PMTB04Jav.gif ### New Feature - Convert Command - 29 April 2016 ![demo][demo-image] From 919bc23a3b1668ef07516f9c1c56e88a3776dc44 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 12:12:13 +0300 Subject: [PATCH 06/17] Update HELP.md --- HELP.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/HELP.md b/HELP.md index 2c73e35..6d484e9 100644 --- a/HELP.md +++ b/HELP.md @@ -2,13 +2,9 @@ ### First Install -First use? you need to watch this ([gif](http://g.recordit.co/2PMTB04Jav.gif)) +First use? you need to watch >>> ([THIS GIF](http://g.recordit.co/2PMTB04Jav.gif)) -![demo][install-image] - -[install-image]: http://g.recordit.co/2PMTB04Jav.gif - -If you don't see any icons, please make sure you have installed your icon fonts. +If you don't see any icons, please make sure you have installed ttf files of your icon fonts. ======= From 49f8cdecbbaa4a2910d8089f05af364fe644364a Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 12:14:52 +0300 Subject: [PATCH 07/17] Update README.md --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index ff6aa40..57a7bff 100644 --- a/README.md +++ b/README.md @@ -9,9 +9,8 @@ Also we've new features like multiple text change, I will share gifs about them ### First Install -First use? you need to watch ([THIS GIF](http://g.recordit.co/2PMTB04Jav.gif)) -##### Please if you have an issue, first watch the gif. - +First use? you need to watch ([THIS VIDEO](https://s3.amazonaws.com/img0.recordit.co/2PMTB04Jav.mp4?AWSAccessKeyId=AKIAINSRFOQXTN4DT46A&Expires=1471428676&Signature=T%2BfMepwF3zCAl7BpVd%2F5Ef3bPj8%3D)) +##### Please if you have an issue, first watch the video. ### New Feature - Convert Command - 29 April 2016 ![demo][demo-image] From 01fca45670253f1ce6d2fa7a81759a252430457d Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 12:15:33 +0300 Subject: [PATCH 08/17] Update HELP.md --- HELP.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/HELP.md b/HELP.md index 6d484e9..f3382c2 100644 --- a/HELP.md +++ b/HELP.md @@ -2,7 +2,8 @@ ### First Install -First use? you need to watch >>> ([THIS GIF](http://g.recordit.co/2PMTB04Jav.gif)) +First use? you need to watch ([THIS VIDEO](https://s3.amazonaws.com/img0.recordit.co/2PMTB04Jav.mp4?AWSAccessKeyId=AKIAINSRFOQXTN4DT46A&Expires=1471428676&Signature=T%2BfMepwF3zCAl7BpVd%2F5Ef3bPj8%3D)) +##### Please if you have an issue, first watch the video. If you don't see any icons, please make sure you have installed ttf files of your icon fonts. From f2cae89131c8a2fa586587a151c01e0b8fede149 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 14:39:32 +0300 Subject: [PATCH 09/17] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 57a7bff..c423a75 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ Also we've new features like multiple text change, I will share gifs about them ### First Install -First use? you need to watch ([THIS VIDEO](https://s3.amazonaws.com/img0.recordit.co/2PMTB04Jav.mp4?AWSAccessKeyId=AKIAINSRFOQXTN4DT46A&Expires=1471428676&Signature=T%2BfMepwF3zCAl7BpVd%2F5Ef3bPj8%3D)) +First use? you need to watch ([THIS VIDEO](http://recordit.co/2PMTB04Jav)) ##### Please if you have an issue, first watch the video. ### New Feature - Convert Command - 29 April 2016 From d926b93b32870180a65279a5a596a43df1022338 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 17 Aug 2016 14:39:49 +0300 Subject: [PATCH 10/17] Update HELP.md --- HELP.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HELP.md b/HELP.md index f3382c2..4e1348c 100644 --- a/HELP.md +++ b/HELP.md @@ -2,7 +2,7 @@ ### First Install -First use? you need to watch ([THIS VIDEO](https://s3.amazonaws.com/img0.recordit.co/2PMTB04Jav.mp4?AWSAccessKeyId=AKIAINSRFOQXTN4DT46A&Expires=1471428676&Signature=T%2BfMepwF3zCAl7BpVd%2F5Ef3bPj8%3D)) +First use? you need to watch ([THIS VIDEO](http://recordit.co/2PMTB04Jav)) ##### Please if you have an issue, first watch the video. If you don't see any icons, please make sure you have installed ttf files of your icon fonts. From 2ed3bf0722c4b0e3c370343aa365c509ec0c2b0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Faruk=20Ate=C5=9F?= Date: Wed, 17 Aug 2016 12:12:05 -0700 Subject: [PATCH 11/17] Add the version number to the Readme This way, people know which version exactly fixed it and helps keep a mental map around versions to use vs. what version they're on, and so forth. (I recommend including version numbers for any date-including, version-based update sections, e.g. the 29 April one too.) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c423a75..3f582ef 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ [![Latest Version](https://img.shields.io/github/release/keremciu/sketch-iconfont.svg?style=flat-square)](https://github.com/keremciu/sketch-iconfont/releases) [![Join the chat at https://gitter.im/keremciu/sketch-iconfont](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/keremciu/sketch-iconfont?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) -### New Features and Fixes - 17 August 2016 +### New Features and Fixes - 17 August 2016 (Version 4.4.0) Hey guys, I've fixed the problem with 3.91 version of Sketch. From e4bb713e63f23a18ed4587f98d3923b63c13d909 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Wed, 24 Aug 2016 13:20:44 +0300 Subject: [PATCH 12/17] Update README.md --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 3f582ef..9e18be0 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,4 @@ + [![PayPal](https://img.shields.io/badge/%24-paypal-f39c12.svg)][paypal-donations] [![Latest Version](https://img.shields.io/github/release/keremciu/sketch-iconfont.svg?style=flat-square)](https://github.com/keremciu/sketch-iconfont/releases) [![Join the chat at https://gitter.im/keremciu/sketch-iconfont](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/keremciu/sketch-iconfont?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) @@ -91,6 +92,8 @@ MIT If you want you can buy me a beer: https://www.paypal.me/keremsevencan :) +[paypal-donations]: https://www.paypal.me/keremsevencan + #### Old version You can see an old version of this plugin here: http://i.imgur.com/EBGmlSe.gif - and you can download it from here: https://github.com/keremciu/sketch-iconfont/tree/oldversion From dd4eb7aec71ec830f76b00088c51dd8c75adff00 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Sat, 10 Sep 2016 18:02:22 +0300 Subject: [PATCH 13/17] fix blacktie font problem #72 --- iconfont.sketchplugin/Contents/Sketch/const/import.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/iconfont.sketchplugin/Contents/Sketch/const/import.js b/iconfont.sketchplugin/Contents/Sketch/const/import.js index 49a885c..2fdcde6 100755 --- a/iconfont.sketchplugin/Contents/Sketch/const/import.js +++ b/iconfont.sketchplugin/Contents/Sketch/const/import.js @@ -22,6 +22,8 @@ var onRun = function(context) { fontname = "Batch" if (fontname == "weather_iconsregular") fontname = "Weather Icons" + if (fontname == "black_tielight") + fontname = "Black Tie Light" // 2. Create Window var wrapper = Library.Widgets.window("Import Font",fontname) From 70e4e2d22b2516f0116073083c883ffdf161707c Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Sat, 10 Sep 2016 18:09:43 +0300 Subject: [PATCH 14/17] this commit closes #72 --- iconfont.sketchplugin/Contents/Sketch/const/import.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/iconfont.sketchplugin/Contents/Sketch/const/import.js b/iconfont.sketchplugin/Contents/Sketch/const/import.js index 2fdcde6..ad1c689 100755 --- a/iconfont.sketchplugin/Contents/Sketch/const/import.js +++ b/iconfont.sketchplugin/Contents/Sketch/const/import.js @@ -24,6 +24,12 @@ var onRun = function(context) { fontname = "Weather Icons" if (fontname == "black_tielight") fontname = "Black Tie Light" + if (fontname == "black_tieregular") + fontname = "Black Tie Regular" + if (fontname == "black_tiebold") + fontname = "Black Tie Bold" + if (fontname == "black_tiesolid") + fontname = "Black Tie Solid" // 2. Create Window var wrapper = Library.Widgets.window("Import Font",fontname) From 4f38976feaa92189995e23453955359f7f56c3e1 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Tue, 4 Oct 2016 14:13:12 +0300 Subject: [PATCH 15/17] Non-text layer selection problem fixed https://twitter.com/mwstrmnn/status/782979129780146178 Multiple selection problems are continuing --- .../Contents/Sketch/const/library.js | 41 ++++++++++++------- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/iconfont.sketchplugin/Contents/Sketch/const/library.js b/iconfont.sketchplugin/Contents/Sketch/const/library.js index 7f6365d..26e660d 100755 --- a/iconfont.sketchplugin/Contents/Sketch/const/library.js +++ b/iconfont.sketchplugin/Contents/Sketch/const/library.js @@ -37,15 +37,38 @@ var Library = { var centered = configs["Centered"].value var replace = configs["Replace"].value color = MSColor.colorWithSVGString(color); + + /* + * create new layer + * if user select non-text layer or replace config is checked, create a new layer for icon + */ + function createNew() { + // create a text layer contains the icon + selection = Library.create.textLayer(doc, artboard, {"text": icon, "name": name, "zoom": zoom, "fontSize": fontsize, "centered": centered, "sketchVersion": sketchVersion}); + + // 8. set selected font + if (sketchVersion > 370) { + selection.setFont([NSFont fontWithName:@""+fontname size:fontsize]) + } else { + [selection setFontPostscriptName:@""+fontname]; + } + + selection.setTextColor(color) + } /* * config replace check * if replace is checked, change selection texts */ - if (replace == 1 && selection && selection.count() >= 1) { + if (replace == 1 && selection && selection.length >= 1) { + for (var j=0; j < selection.length; j++) { + selected = selection[j] + + if (selected.class() != "MSTextLayer") { + createNew() + continue; + } - for (var j=0; j < selection.count(); j++) { - selected = selection[j] // set icon selected.setStringValue(icon) // set icon name @@ -60,17 +83,7 @@ var Library = { } } else { - // create a text layer contains the icon - selection = Library.create.textLayer(doc, artboard, {"text": icon, "name": name, "zoom": zoom, "fontSize": fontsize, "centered": centered, "sketchVersion": sketchVersion}); - - // 8. set selected font - if (sketchVersion > 370) { - selection.setFont([NSFont fontWithName:@""+fontname size:fontsize]) - } else { - [selection setFontPostscriptName:@""+fontname]; - } - - selection.setTextColor(color) + createNew() } }, // From 444d8735fe16afaa3a9e07c0b76da2749892a3a7 Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Tue, 4 Oct 2016 14:13:52 +0300 Subject: [PATCH 16/17] release version update --- iconfont.sketchplugin/Contents/Sketch/manifest.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iconfont.sketchplugin/Contents/Sketch/manifest.json b/iconfont.sketchplugin/Contents/Sketch/manifest.json index f7e36df..09e7066 100755 --- a/iconfont.sketchplugin/Contents/Sketch/manifest.json +++ b/iconfont.sketchplugin/Contents/Sketch/manifest.json @@ -76,8 +76,8 @@ ] }, "identifier" : "com.keremciu.sketch.iconfont", - "version" : "4.4.0", + "version" : "4.4.2", "description" : "Use icons like a boss.", "name" : "Icons", "authorEmail" : "info@kerem.ws" -} \ No newline at end of file +} From b9abbdbba6a249b019fe877ec94b07bca4d54e3e Mon Sep 17 00:00:00 2001 From: Kerem Sevencan Date: Tue, 4 Oct 2016 14:14:54 +0300 Subject: [PATCH 17/17] Update README.md --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 9e18be0..d084aa8 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,10 @@ [![Latest Version](https://img.shields.io/github/release/keremciu/sketch-iconfont.svg?style=flat-square)](https://github.com/keremciu/sketch-iconfont/releases) [![Join the chat at https://gitter.im/keremciu/sketch-iconfont](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/keremciu/sketch-iconfont?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) +##### Non-text layer selection problem fixed - 4 October 2016 (Version 4.4.2) + +Problem here https://twitter.com/mwstrmnn/status/782979129780146178 + ### New Features and Fixes - 17 August 2016 (Version 4.4.0) Hey guys, I've fixed the problem with 3.91 version of Sketch.