-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack week planning #83
Comments
Not sure about the best option for |
@fchollet I might need more details for the pytorch backend. Should I just try to replicate backend/tensorflow/numpy.py line for line? The entire I also don't see any unit tests (at least in the |
Just
This is indirectly tested by unit tests in We could also add a |
Jonathan, I think I may have not enough on my list for the hack week so I
can help out with the PyTorch if you’d like (sounds like fun to me)
I’ve added a few things to backend/ and ops/ so I think I have a good sense
of what needs to happen.
…On Sun, May 7, 2023 at 10:46 AM François Chollet ***@***.***> wrote:
I might need more details for the pytorch backend. Should I just try to
replicate backend/tensorflow/numpy.py
<https://github.com/keras-team/keras-core/blob/main/keras_core/backend/tensorflow/numpy.py>
line for line?
Just pytorch/numpy.py for now. Yes, all the same functions as in
tensorflow/numpy.py need to be implemented. Ramesh is also taking a look
at pytorch/nn.py.
I also don't see any unit tests (at least in the backend/ folder. How do
we verify the deliverables?
This is indirectly tested by unit tests in keras_core/operations/. I
think you should be able to set the backend as "pytorch" (we'll need to
edit backend/__init__.py to make it work) and run those tests.
We could also add a keras_core/backend/tests/ directory to cover
cross-backend function tests without relying on any other Keras
functionality. It would probably be a good move since it makes it easier
for folks to add new backends.
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOHB3ZXB7DRS4WFWE2UR3XE7GXLANCNFSM6AAAAAAXVCRMQE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@AakashKumarNain are you still working on the PyTorch dataloader? |
@fchollet didn't get much time to work during weekdays. Was planning to work on it over the weekend but if someone else wants to pick it up right aways, I am okay with it |
It's still yours if you want to do it! |
I will work on it and will update you on the status on Monday |
@fchollet now that torch dataloader adapter has been merged, is there any unassigned task that I can work on in the coming weeks? |
Yes, thanks for offering! The next big sprint is going to be porting Keras Applications. We have 12 separate architectures to port. You could be working on e.g. ResNet, ResNetV2, MobileNet, etc. I will port the first application (likely VGG) within a few days. |
Thanks. I will start with ResNet |
Thanks a lot for the help! 👍 |
No problem. This project is way too close to my heart 🥂 |
Participants:
See proposed assignments below.
Some of the assignment buckets may not last the week -- we will reshuffle assignments as we make progress. If we reach a sufficient degree of feature completeness mid-week, we can move on to backwards compatibility testing.
@fchollet
Layers:
Wrapped layers:
@chenmoneygithub
@sampathweb
Callbacks:
@qlzh727
@ianstenbit
keras_core/optimizers/schedules/
)Callbacks:
@divyashreepathihalli
Layers:
Wrapped layers:
@jbischof
keras_core/backend/pytorch/numpy.py
@rchao
Layers:
@mattdangerw
Layers:
@hertschuh
Layers:
@grasskin
Metrics
Callbacks:
@nkovela1
Layers:
@haifeng-jin
The text was updated successfully, but these errors were encountered: