Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: check if sh.keptn.event.configure-monitor.finished is available after calling keptnConfigureMonitoring #94

Open
3 tasks
christian-kreuzberger-dtx opened this issue Feb 10, 2022 · 0 comments
Labels
type:feature New feature or request that provides value to the stakeholders/end-users

Comments

@christian-kreuzberger-dtx
Copy link
Contributor

christian-kreuzberger-dtx commented Feb 10, 2022

After #80 has been implemented, we should also check for sh.keptn.event.configure-monitor.finished cloudevent with result/status check, and print the message that is returned.

More insights

Right now we assume that monitoring is configured properly when the event endpoint of Keptn responds with HTTP status 200:

            if (configureMonitoringResponse.status == 200) {
                echo "Successfully configured monitoring for: ${monitoring}"
                echo "body: ${configureMonitoringBody}"
            } else {
                echo "Couldnt configure monitoring for ${monitoring}: " + configureMonitoringResponse.content
                echo "body: ${configureMonitoringBody}"
            }    

This could lead to problems, as Keptn will almost always accept the event (unless it's malformed).
HTTP Status 200 here does not indicate whether monitoring was configured properly.

This requires the respective service (e.g., prometheus-service, dynatrace-service) to respond with a sh.keptn.event.configure-monitor.finished CloudEvent).

Definition of Done

  • Implementation checks for the respective CloudEvent and prints message from CloudEvent
  • Pipeline fails if keptnConfigureMonitoring is called and no CloudEvent is retrieved, or status/result of CloudEvent indicate a failure/problem
  • FEATURES.md updated
@christian-kreuzberger-dtx christian-kreuzberger-dtx added type:bug Something is not working as intended/documented type:feature New feature or request that provides value to the stakeholders/end-users and removed type:bug Something is not working as intended/documented labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request that provides value to the stakeholders/end-users
Projects
None yet
Development

No branches or pull requests

1 participant