Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a resource fails but does not break the pipeline #46

Open
2 tasks
christian-kreuzberger-dtx opened this issue Nov 12, 2021 · 1 comment
Open
2 tasks
Labels
type:bug Something is not working as intended/documented

Comments

@christian-kreuzberger-dtx
Copy link
Contributor

Using 1.4.0 I ran into the following issue while trying to add a file:

metadata endpoint exists...
keptnVersion = 0.10.0
adding resource /home/vsts/work/1/s/.keptn/helm/foobar.tgz to keptn target helm/foobar.tgz
{ Error: Request failed with status code 400
    at createError (/home/vsts/work/_tasks/AddKeptnResourceTask_f423c3f9-bd6d-11ea-b3de-0242ac130004/1.1.0/node_modules/axios/lib/core/createError.js:16:15)
    at settle (/home/vsts/work/_tasks/AddKeptnResourceTask_f423c3f9-bd6d-11ea-b3de-0242ac130004/1.1.0/node_modules/axios/lib/core/settle.js:17:12)
    at IncomingMessage.handleStreamEnd (/home/vsts/work/_tasks/AddKeptnResourceTask_f423c3f9-bd6d-11ea-b3de-0242ac130004/1.1.0/node_modules/axios/lib/adapters/http.js:293:11)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
...
     data: { code: 400, message: 'Could not unarchive Helm chart' } },

image

This is not good, because as a user, you are under the impression that everything worked, although it didn't.

Definition of Done

  • Add Resource task fails if the corresponding API call fails
  • The response error message is shown instead of a stacktrace

However, the pipeline continued.

@christian-kreuzberger-dtx christian-kreuzberger-dtx added the type:bug Something is not working as intended/documented label Nov 12, 2021
@Raffy23
Copy link
Member

Raffy23 commented Mar 23, 2022

The problem with the task not failing seems to have already been fixed in the master branch.
With #93 the error message should be more readable. Could not unarchive Helm chart is displayed as message instead of the generic Request failed with status code 400 message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something is not working as intended/documented
Projects
None yet
Development

No branches or pull requests

2 participants