Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to move to v1.0.0? #74

Open
lopez86 opened this issue May 26, 2022 · 1 comment
Open

When to move to v1.0.0? #74

lopez86 opened this issue May 26, 2022 · 1 comment

Comments

@lopez86
Copy link
Collaborator

lopez86 commented May 26, 2022

I think it might be good to move the version to v1.0.0 soon, but I think it might be good to have an issue open for any discussion. There are several things that I think probably should be done before that happens:

  1. Figure out a more generic saving/loading scheme that can be extended for different language models besides just the provided LanguageModel class. See this issue.
  2. Remove explicit dependence on kenlm in the AbstractLanguageModel and Decoder classes. See this issue
  3. Make sure the documentation and notebooks are fully up to date
  4. (Maybe) Refactor so that the kenlm classes are contained in their own file instead of in the main language model and decoder files. This would break imports since anything mentioning kenlm would now be in a different module.
  5. (Maybe) Add an abstract decoder class to allow for extending with alternate decoder classes? The most basic API would just require a decode() and a decode_batch() function but decode_beams() and decode_beams_batch() might be useful for beam-search decoders
  6. (Maybe) There have been some requests for including per-word scores in the output. Settling on a way to do that might be another good feature improvement to aim for.
@yashjogi
Copy link

yashjogi commented Jan 16, 2023

On Point 6:
Just like how time-stamps are being calculated for each word by keeping two variables "frame_list" and "frames", in a similar fashion we can have two more variables "word_confidence_list" and "word_confidence", and we can update them in a way similar to how we update time stamps. However, unlike timestamps, we will have to make changes in _merge_beams function to merge the word confidence scores as well, just like how logit scores are merged.

Is that correct @lopez86 ? I have never contributed to any open source project on GitHub, it'd be great if I can contribute on this word confidence feature.

cc: @patrickvonplaten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants