-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL: Update GraphiQL version #569
Comments
Also relevant in this context, coming from #554 (comment): Security and compatibility improvements needed for external dependencies. Several concerns with the current implementation:
[security] - <link href="//cdn.jsdelivr.net/npm/graphiql@{{ GRAPHIQL_VERSION }}/graphiql.css" rel="stylesheet"/>
- <script src="//cdn.jsdelivr.net/npm/[email protected]/fetch.min.js"></script>
- <script src="//cdn.jsdelivr.net/npm/[email protected]/umd/react.production.min.js"></script>
- <script src="//cdn.jsdelivr.net/npm/[email protected]/umd/react-dom.production.min.js"></script>
- <script src="//cdn.jsdelivr.net/npm/graphiql@{{ GRAPHIQL_VERSION }}/graphiql.min.js"></script>
+ <link
+ href="https://cdn.jsdelivr.net/npm/graphiql@{{ GRAPHIQL_VERSION }}/graphiql.css"
+ rel="stylesheet"
+ integrity="sha384-[GET-ACTUAL-HASH]"
+ crossorigin="anonymous"
+ />
+ <script
+ src="https://cdn.jsdelivr.net/npm/[email protected]/umd/react.production.min.js"
+ integrity="sha384-[GET-ACTUAL-HASH]"
+ crossorigin="anonymous"
+ ></script>
+ <script
+ src="https://cdn.jsdelivr.net/npm/[email protected]/umd/react-dom.production.min.js"
+ integrity="sha384-[GET-ACTUAL-HASH]"
+ crossorigin="anonymous"
+ ></script>
+ <script
+ src="https://cdn.jsdelivr.net/npm/graphiql@{{ GRAPHIQL_VERSION }}/graphiql.min.js"
+ integrity="sha384-[GET-ACTUAL-HASH]"
+ crossorigin="anonymous"
+ ></script> Note: Replace
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@coderabbitai recommended:
Consider upgrading GraphiQL version.
The template uses GraphiQL v0.12.0 which is significantly outdated. The latest stable version is 3.0.1 which includes security fixes, performance improvements, and new features.
Apply this diff to update the version:
📝 Committable suggestion
Originally posted by @coderabbitai[bot] in #554 (comment)
The text was updated successfully, but these errors were encountered: