From e17d19215571756e9304b0085c8ca17a32b6e19b Mon Sep 17 00:00:00 2001 From: isabelmsft <67024108+isabelmsft@users.noreply.github.com> Date: Wed, 21 Jun 2023 11:19:01 -0700 Subject: [PATCH] [GCU] Skip test replace fec, test update speed (#8626) --- .../conditional_mark/tests_mark_conditions.yaml | 12 +++++------- tests/generic_config_updater/test_eth_interface.py | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml b/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml index 42a3b7a7a4..e18d3914f4 100644 --- a/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml +++ b/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml @@ -463,12 +463,10 @@ generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates: generic_config_updater/test_eth_interface.py::test_replace_fec: skip: - reason: '1. replace_fec ethernet test is not supported on virtual switch - 2. Skip on M0 and Mx topo due to DUT interfaces do not support config fec' - conditions_logical_operator: OR + reason: 'replace_fec ethernet test depends on StateDB values. GCU needs to be updated to consider StateDB' conditions: - - "platform in ['x86_64-kvm_x86_64-r0']" - - "topo_type in ['m0', 'mx'] and https://github.com/sonic-net/sonic-mgmt/issues/8600" + - https://github.com/sonic-net/sonic-mgmt/issues/8600 + generic_config_updater/test_eth_interface.py::test_toggle_pfc_asym: skip: @@ -477,8 +475,8 @@ generic_config_updater/test_eth_interface.py::test_toggle_pfc_asym: - "asic_type in ['cisco-8000']" generic_config_updater/test_eth_interface.py::test_update_speed: - xfail: - reason: 'Xfail this script due to this not being a production scenario and misleading StateDB output for valid speed' + skip: + reason: 'Skip this script due to this not being a production scenario and misleading StateDB output for valid speed' conditions: - https://github.com/sonic-net/sonic-mgmt/issues/8143 diff --git a/tests/generic_config_updater/test_eth_interface.py b/tests/generic_config_updater/test_eth_interface.py index cd24ac4b4e..5bdade097e 100644 --- a/tests/generic_config_updater/test_eth_interface.py +++ b/tests/generic_config_updater/test_eth_interface.py @@ -205,7 +205,7 @@ def test_toggle_pfc_asym(duthost, ensure_dut_readiness, pfc_asym): def test_replace_fec(duthost, ensure_dut_readiness, fec): json_patch = [ { - "op": "replace", + "op": "add", "path": "/PORT/Ethernet0/fec", "value": "{}".format(fec) }