From 68d2b0a5d824f9c0e2f54f60bf33dfb65f117cce Mon Sep 17 00:00:00 2001
From: kelpsyberry <138107494+kelpsyberry@users.noreply.github.com>
Date: Sat, 20 Jan 2024 02:17:29 +0100
Subject: [PATCH] Fix macOS app bundle workflow and some warnings

---
 .../workflows/build-release-macos-app-bundles.yml    | 12 ++++++------
 core/src/audio/channel.rs                            |  1 +
 frontend/desktop/src/ui.rs                           |  2 ++
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build-release-macos-app-bundles.yml b/.github/workflows/build-release-macos-app-bundles.yml
index bdf7e69..d738ba9 100644
--- a/.github/workflows/build-release-macos-app-bundles.yml
+++ b/.github/workflows/build-release-macos-app-bundles.yml
@@ -70,8 +70,8 @@ jobs:
         --package dust-desktop
 
         lipo
-        target/x86_64-apple-darwin/dust-desktop
-        target/aarch64-apple-darwin/release/dust-desktop
+        target/x86_64-apple-darwin/ci/dust-desktop
+        target/aarch64-apple-darwin/ci/dust-desktop
         -create
         -output Dust.app/Contents/MacOS/Dust
 
@@ -100,8 +100,8 @@ jobs:
         --package dust-desktop
 
         lipo
-        target/x86_64-apple-darwin/dust-desktop
-        target/aarch64-apple-darwin/release/dust-desktop
+        target/x86_64-apple-darwin/ci/dust-desktop
+        target/aarch64-apple-darwin/ci/dust-desktop
         -create
         -output Dust.app/Contents/MacOS/Dust
       
@@ -130,8 +130,8 @@ jobs:
         --package dust-desktop
 
         lipo
-        target/x86_64-apple-darwin/dust-desktop
-        target/aarch64-apple-darwin/release/dust-desktop
+        target/x86_64-apple-darwin/ci/dust-desktop
+        target/aarch64-apple-darwin/ci/dust-desktop
         -create
         -output Dust.app/Contents/MacOS/Dust
 
diff --git a/core/src/audio/channel.rs b/core/src/audio/channel.rs
index bd1c315..15f6ed7 100644
--- a/core/src/audio/channel.rs
+++ b/core/src/audio/channel.rs
@@ -338,6 +338,7 @@ impl Channel {
     }
 
     #[inline]
+    #[allow(clippy::unused_self)]
     fn keep_last_sample(&mut self) {
         #[cfg(feature = "xq-audio")]
         self.hist.copy_within(1.., 0);
diff --git a/frontend/desktop/src/ui.rs b/frontend/desktop/src/ui.rs
index e9a637c..ea40f0e 100644
--- a/frontend/desktop/src/ui.rs
+++ b/frontend/desktop/src/ui.rs
@@ -564,6 +564,8 @@ impl UiState {
 
         let frame_tx = self.frame_tx.take().unwrap();
 
+        // TODO: False positive
+        #[allow(clippy::useless_asref)]
         let audio_tx_data = self
             .audio_channel
             .as_ref()