Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Geyser Timers #28

Open
kelly-cs opened this issue Jul 22, 2020 · 2 comments
Open

Fix Geyser Timers #28

kelly-cs opened this issue Jul 22, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kelly-cs
Copy link
Owner

An anomaly is taking place that is causing remaining construction time of geysers to be far too low in the second half of results of the simulation. In addition to that, their "being_constructed" flag is set to true before they are built. It seems as if the variables are getting messed with before that branch is simulated.

@kelly-cs kelly-cs added the bug Something isn't working label Jul 22, 2020
@kelly-cs kelly-cs self-assigned this Jul 22, 2020
@kelly-cs
Copy link
Owner Author

This issue is really deep-seated. It might be worthwhile to simply refactor how this works entirely and improve the code quality before doing any further investigation into this. The issue seems to be affecting the geyser timers/in_construction flags in particular, and seem to be affecting later build orders.

@kelly-cs
Copy link
Owner Author

TODO:
Turn geysers into objects and handle processing there, and not as much inside of Base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant