Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Base.py #21

Open
kelly-cs opened this issue Jul 5, 2020 · 2 comments
Open

Refactor Base.py #21

kelly-cs opened this issue Jul 5, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kelly-cs
Copy link
Owner

kelly-cs commented Jul 5, 2020

Base.py is considerably out of form with the rest of the app right now, and has mixed responsibilities.

Base represents the main townhall building for each race, the hatchery, command center, or nexus. In addition to that, it also retains a record of how many workers it has, calculates income, and handles some logic regarding moving workers around.

The way that geysers are implemented should be redone, and we should try to simplify this file as much as possible to make it more readable.
@kelly-cs kelly-cs added enhancement New feature or request good first issue Good for newcomers labels Jul 5, 2020
@kelly-cs
Copy link
Owner Author

Cleaned up geyser code in recent dev commit

@kelly-cs
Copy link
Owner Author

worker handling could maybe he offloaded to the Building class, not sure if worthwhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kelly-cs