Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizational Security Concerns #184

Open
dek39 opened this issue Dec 31, 2020 · 1 comment
Open

Organizational Security Concerns #184

dek39 opened this issue Dec 31, 2020 · 1 comment

Comments

@dek39
Copy link

dek39 commented Dec 31, 2020

Unfortunately, my organization will not allow download of the Sprint Goal add-in due to security concerns. I wanted to provide these concerns to you, hoping that if any are easily resolvable that I will be able to download it in the future, if resolved. This is the feedback from our security review:

  1. The javascript files were minimized when they weren't supposed to be.
  2. Within those minimized scripts, there was some payment module information that didn't look right. I'm not sure why it would reference payment info when this has nothing to do with payment information.
  3. Sending any information outside of the organization is a violation of security and could be cause for termination (which appears to happen with this add-in).
  4. It's actually pulling in javascript from outside of the organization's walls; this is a violation and goes against security practices as it opens up our system to script injection.

Please let me know if there is any way to get support to address any of these!

@keesschollaart81
Copy link
Owner

keesschollaart81 commented Feb 23, 2021

  1. I don't minimize the code, it is packed/bundled by WebPack in a single file. This is because and AzD extension is supposed to be self contained. For multiple reasons I prefer a single file containing all the packages I need. (bundling != minimizing)
    image
  2. My code does not reference an external library (check the .html files). All packages I depend upon are listed in packages.json. These packages are included in the bundle which you can see in the browsers network tab (eg: sprint-goal.js) -- It could be possible that any of these dependencies dynamically loads an external resource, I am not aware of that and can also not see that happen in my tests:
    image
    ^^ all of these are Microsoft owned hosts
  3. Totally agree
  4. Totally agree

By the way, I checked 1) and 2) with the latest 5.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants