Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the new Cosmos SIGN_MODE_DIRECT scheme #307

Open
mrnerdhair opened this issue Mar 21, 2022 · 0 comments
Open

Support the new Cosmos SIGN_MODE_DIRECT scheme #307

mrnerdhair opened this issue Mar 21, 2022 · 0 comments

Comments

@mrnerdhair
Copy link
Collaborator

The Cosmos SDK has changed how it serialized transactions before signing. We need to update the firmware to create signatures using the new SIGN_MODE_DIRECT. After the functionality is solidified, we'll also need to update hdwallet-keepkey accordingly.

Questions:

  • Should we retain the old SIGN_MODE_AMINO as an option?
  • How will clients tell which type of signature they'll be getting?

Reference: shapeshift/hdwallet#414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrnerdhair