fix: improve convertion errors and handle invalid ABI #387
+65
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
shamsasari
reviewed
Sep 27, 2024
| #[derive(Debug, thiserror::Error)] | ||
| pub enum ClientError { | ||
| #[error("Encountered a request error: {0}")] | ||
| ReqwestError(#[from] reqwest::Error), |
There was a problem hiding this comment.
From what I've seen of Rust errors, shouldn't this just be Reqwest? The enum is already named "Error".
shamsasari
reviewed
Sep 27, 2024
| #[error("Encountered a request error: {0}")] | ||
| ReqwestError(#[from] reqwest::Error), | ||
| #[error("Encountered a custom error: {0}")] | ||
| Msg(String), |
There was a problem hiding this comment.
Custom would be a better variant name
shamsasari
reviewed
Sep 27, 2024
Comment on lines
+42
to
+47
| match self.get_serialized_contract_class() { | ||
| Ok(serialized_class) => { | ||
| let contract_class = serde_json::from_slice(serialized_class)?; | ||
| Ok(contract_class) | ||
| } | ||
| Err(e) => Err(e), |
There was a problem hiding this comment.
I think you can improve this by using Result.and_then
HermanObst
reviewed
Sep 27, 2024
| @@ -140,7 +141,8 @@ impl TryFrom<&FlattenedSierraClass> for FlattenedSierraClassWithAbi { | |||
| type Error = serde_json::error::Error; | |||
|
|
|||
| fn try_from(sierra_class: &FlattenedSierraClass) -> Result<Self, Self::Error> { | |||
| let abi: Option<cairo_lang_starknet_classes::abi::Contract> = serde_json::from_str(&sierra_class.abi)?; | |||
| let abi: Option<cairo_lang_starknet_classes::abi::Contract> = | |||
| serde_json::from_str(&sierra_class.abi).unwrap_or_default(); | |||
There was a problem hiding this comment.
@whichqua what default would represent here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: N/A
Type
Description
Breaking changes?