-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: add pie validity check to prove block #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this to execute_txs_and_run_os()
so that it will be checked in our integration tests as well
.await | ||
.map_err(debug_prove_error) | ||
.expect("Block could not be proven"); | ||
|
||
assert!(pie.run_validity_checks().is_ok()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but an expect()
with a clear message would be better
Problem: We weren't performing validation checks on the PIEs we were generating.
Fix: Adds run_validity_checks() in our prove block tests