-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: build script, remove async for now, remove build artifacts #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we recompile even if the compiled files already exist ? At least make sure they haven't changed
In this case the GH Action doesn't cache the build dir so it will recompile the test files each time. IMO, it's a better dev experience if we don't recompile a contract that is already in the build dir locally. If you've made a change to that contract simply delete the compiled contract from build and re-run the tests. |
Ok will just need to be careful if we add cache |
a125b55
to
fc0bb8e
Compare
dev: build script, remove async for now, remove build artifacts
dev: build script, remove async for now, remove build artifacts
once we identify a place that we can utilize threading we can add back in async