Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: build script, remove async for now, remove build artifacts #23

Merged
merged 10 commits into from
Sep 27, 2023

Conversation

drspacemn
Copy link
Contributor

  • build script
  • remove async for now
  • remove build artifacts

once we identify a place that we can utilize threading we can add back in async

Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we recompile even if the compiled files already exist ? At least make sure they haven't changed

tests/snos.rs Outdated Show resolved Hide resolved
@drspacemn
Copy link
Contributor Author

drspacemn commented Sep 27, 2023

Shouldn't we recompile even if the compiled files already exist ? At least make sure they haven't changed

In this case the GH Action doesn't cache the build dir so it will recompile the test files each time. IMO, it's a better dev experience if we don't recompile a contract that is already in the build dir locally.

If you've made a change to that contract simply delete the compiled contract from build and re-run the tests.

@EvolveArt
Copy link
Collaborator

Shouldn't we recompile even if the compiled files already exist ? At least make sure they haven't changed

In this case the GH Action doesn't cache the build dir so it will recompile the test files each time. IMO, it's a better dev experience if we don't recompile a contract that is already in the build dir locally.

If you've made a change to that contract simply delete the compiled contract from build and re-run the tests.

Ok will just need to be careful if we add cache

@drspacemn drspacemn merged commit 06793f2 into main Sep 27, 2023
4 checks passed
@drspacemn drspacemn deleted the dev/cleanup branch September 27, 2023 09:43
drspacemn added a commit that referenced this pull request Sep 27, 2023
dev: build script, remove async for now, remove build artifacts
drspacemn added a commit that referenced this pull request Sep 27, 2023
dev: build script, remove async for now, remove build artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants