Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve tests of position_pricing_utils library. #489

Open
sparqet opened this issue Oct 4, 2023 · 4 comments
Open

test: Improve tests of position_pricing_utils library. #489

sparqet opened this issue Oct 4, 2023 · 4 comments
Labels
enhancement New feature or request testing

Comments

@sparqet
Copy link
Collaborator

sparqet commented Oct 4, 2023

Description

Implement and improve tests of position_pricing_utils library.

File: test/pricing/position_pricing_utils.cairo.

Acceptance criteria

  • Unit tests (nominal and failure) are implemented and passing.
@sparqet sparqet added enhancement New feature or request testing labels Oct 4, 2023
@eytanlvy
Copy link
Contributor

eytanlvy commented Oct 4, 2023

Can I take this one?

@sparqet
Copy link
Collaborator Author

sparqet commented Oct 5, 2023

Sure !

@Sk8erboi84
Copy link
Collaborator

Any updates ? @eytanlvy

@givingmittal
Copy link

Hey @sparqet @Sk8erboi84, Please assign it to me if @eytanlvy is no longer working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sparqet @eytanlvy @Sk8erboi84 @givingmittal