Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test_deposit_event_emitted test #601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ccolorado
Copy link

@ccolorado ccolorado commented Dec 18, 2023

  • adds tests for DepositEvents @ tests/event/test_deposit_event_emitted.cairo
  • adds scarb test script entry on Scarb.toml
  • adjusts devcontainer memory to fit scarb compile
  • adds .editorconfig for specifying

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Testing

What is the current behavior?

Missing tests for DepositEvents functions of the EventEmitter contract
Resolves: #322

What is the new behavior?

add tests for DepositEvents functions of the EventEmitter contract

  • Test for emit_deposit_created using spy_events must be included
  • Test for emit_deposit_executed using spy_events must be included
  • Test for emit_deposit_cancelled using spy_events must be included

Does this introduce a breaking change?

No

Other information

Some optional tweaks submitted for consideration:
Increasing memory for the devcontainer
Including a .editorconfig (form editorconfig.org)

@ccolorado ccolorado marked this pull request as ready for review December 24, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: add tests for DepositEvents functions of the EventEmitter contract.
1 participant