Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kedro PR will break parameters in kedro-viz #1933

Closed
1 task done
bpmeek opened this issue May 31, 2024 · 1 comment
Closed
1 task done

Kedro PR will break parameters in kedro-viz #1933

bpmeek opened this issue May 31, 2024 · 1 comment

Comments

@bpmeek
Copy link

bpmeek commented May 31, 2024

Description

If PR is merged, it will affect the behavior of showing parameters in kedro-viz

Context

The unpacked parameters won't show up, nor will the parent dictionary

Steps to Reproduce

  1. Create the example project using kedro new
  2. Change pipelines/data_science/nodes.py, pipelines/data_science/pipelines.py as shown in the ticket
  3. Start kedro-viz
  4. Select the option to show parameters

Expected Result

Either the unpacked dictionary or the entire entry should show

Actual Result

Nothing

-- If you received an error, place it here.
-- Separate them if you have more than one.

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version: Chrome 125.0.6422.113
  • Operating system and version: MacOS 14.5
  • NodeJS version used (if relevant):
  • Kedro version used (if relevant): Referenced in PR
  • Python version used (if relevant): 3.10.14

Checklist

  • Include labels so that we can categorise your issue
@astrojuanlu
Copy link
Member

Hi @bpmeek , we're slowly catching up with backlog items, sorry about our slow response.

I'm not up to date with kedro-org/kedro#3905 but my understanding is that Kedro-Viz, as consumer of Kedro, shouldn't break - otherwise that would be a sign of a breaking change, that should not have happened until the next Kedro release, 0.20.*.

In other words, the PR should be backwards compatible.

The heads up is appreciated 🙏🏼 but for now there's nothing for us to do here.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done in Kedro-Viz Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants