Support for Azure Default Credentials in the Scaler #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
| @@ -25,7 +26,11 @@ public Worker(CosmosDbConfig cosmosDbConfig, ILogger<Worker> logger) | |||
|
|
|||
| public override async Task StartAsync(CancellationToken cancellationToken) | |||
| { | |||
| Database leaseDatabase = await new CosmosClient(_cosmosDbConfig.LeaseConnection) | |||
| var cosmosClient = _cosmosDbConfig.Connection.Contains("AccountKey") | |||
There was a problem hiding this comment.
Hi @karpikpl, the PR looks good overall. This particular cosmosClient should be based on LeaseConnection configuration as the sample code aims to work even when the Cosmos DB accounts are different for the monitored and lease containers. I have a couple of minor changes planned and should be able to fix this one too in the new PR if that's okay with you.
I have a few questions on AAD identity-based access. Would be helpful if you have answer to some or all of them.
- Were you able to test the demo code with default credentials? I had tough time trying to set the permissions as none of the existing role (and with custom role) seem to give me access to create database, etc.
- Do we have steps to allow use of default credentials inside locally running Docker container?
- Do we know the minimum (or a superset of) permissions required by the Cosmos DB scaler to be able to check change feeds and generate necessary KEDA metrics? If so, I can document and publish it in this repo.
There was a problem hiding this comment.
@karpikpl - Reminder on this one. Let me know if you know answers to any of the questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Azure Default Credentials in the Scaler
Checklist
Fixes #49