-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential leak in ImagePipelineDelgate #807
Comments
Looks like tests will fail as ImagePipelineDefaultDelgate wont hang around since its now weak. Hmm guess you cant have self as delegate like we are doing in order to avoid retain cycle Should we be doing something like this
|
The design matches |
Fair enough, we'll change our implementation accordingly. Maybe worth mentioning this in the doc as delegate are generally assumed to be weak |
wonder if my other change here makes sense #806 |
Hi
Should the ImagePipelineDelgate be declared as weak var. We are seeing a leak in the app regarding this.
We have ImagePipeline declared as a lazy var in a Class, this results in a retain cycle and a leak
I have a PR open here #806
Thanks in advance!
The text was updated successfully, but these errors were encountered: