Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashdash comment breaks when string values contain a closing curly brace #8

Open
sargunv opened this issue Sep 29, 2021 · 2 comments

Comments

@sargunv
Copy link

sargunv commented Sep 29, 2021

image

example text:

/-command "twitter" "tw" {
    rules {
        // profiles (format: @username)
        custom "https://twitter.com/{/username}" \
            regexp="^@(?P<username>[A-Za-z_]+)$"

        noargs "https://twitter.com"
        freeform "https://twitter.com/search?q={ARGS}"
    }

    tests {
        case "tw" "https://twitter.com"
        case "tw @sargunv" "https://twitter.com/sargunv"
        case "tw sargun vohra" "https://twitter.com/search?q=sargun%20vohra"
    }
}
@binhonglee
Copy link

It seems like it just breaks if you start the line with slash dash in general.

@errhammr
Copy link

errhammr commented Apr 22, 2022

I'm using the KDL plugin version 1.1.0 1.3.1 on VSCodium. Slashdash comments at the beginning of a line or at the beginning of a curly brace seem to terminate at the first closing curly brace, regardless of nesting.

In the following screenshots, the comment is supposed to reach all the way down to the very bottom but it only gets to the first closing curly brace.

kdl-vscodium-1
kdl-vscodium-2

Also, if the first closing curly brace is within a string, it completely breaks syntax highlighting for the rest of the following document. The ending quote (") of the string is interpreted as the starting quote of a new string.

kdl-vscodium-3

I feel like these problems are related to the issues discussed earlier in this thread so I didn't open a new issue for that.


Edit: I updated the plugin from 1.1.0 to 1.3.1 which has the same issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants