Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EditorConfig as for autoformat #96

Open
toastal opened this issue Dec 7, 2024 · 1 comment
Open

Use EditorConfig as for autoformat #96

toastal opened this issue Dec 7, 2024 · 1 comment

Comments

@toastal
Copy link

toastal commented Dec 7, 2024

I would like to see EditorConfig be used as a fallback for the default spacing when no format values are specified.

Advantages: keep indentation config in one place; no desync in config/execution; no need to pass arguments or override; ability to specify different values for different files/directories if needed for vendored third-party files; autoformat would use it by default

Disadvantages: requires parsing .editorconfig, a third-party format & would incur additional dependencies; minor endorsement of EditorConfig as a project since it would get special support

@zkat
Copy link
Member

zkat commented Dec 7, 2024

I think I would consider editorconfig support in the main API itself to be out of scope. We don’t even deal with files!

Where I do think it makes sense is as part of a standalone kdlfmt tool, which would be good to have in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants