Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GStorm does not take fields from inherited class as part of the table #17

Open
aadamovich opened this issue Dec 16, 2014 · 3 comments
Open

Comments

@aadamovich
Copy link

No description provided.

@kdabir
Copy link
Owner

kdabir commented Dec 16, 2014

Yeah, that was kinda intended behaviour to take only the fields declared in the class into consideration.

Inheritance would require implementing Table-per-Hierarchy vs Table-per-Concrete-Class vs Table-per-Subclass strategies to avoid duplicate columns and which may require referencing to data in base tables. Which is departure from single table philosophy of gstorm. Until I see pressing need, I think it's better to keep it simple.

Again, it's possible to provide just the most basic implementation which creates tables for each concrete class without worrying about any column dedupe strategy. Perhaps matter of time.

@aadamovich
Copy link
Author

I think basic implementation would be a logical choice for SINGLE Table ORM :) This can also be handled through annotation somehow e.g. @MapInheritedFields

@kdabir
Copy link
Owner

kdabir commented Dec 17, 2014

Yeah. I am keeping the issue open. Will most likely need to update *MetaData classes to get it to work. Will try it in some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants