Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: When using push, check the necessary fields in the kcl.mod, such as name or version #508

Open
zong-zhe opened this issue Oct 29, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@zong-zhe
Copy link
Contributor

Enhancement

@zong-zhe zong-zhe self-assigned this Oct 29, 2024
@zong-zhe zong-zhe added the enhancement New feature or request label Oct 29, 2024
@ravjot07
Copy link

Hi @zong-zhe,

I’d like to contribute an enhancement to the kpm project by validating the name and version fields in the kcl.mod file during the push command. My approach involves adding a validateKclPkgFields function to ensure these fields are non-empty, improving package integrity before pushing to the OCI registry.
Can you verify my approach so i can start working on it....

@zong-zhe
Copy link
Contributor Author

Hi @ravjot07

Thanks very much, and we can move forward with this part of the work as planned. You can complete some necessary preparations through the paperwork solution. You can add some paperwork solution PRs to this directory: https://github.com/kcl-lang/kpm/tree/main/research/design-doc.

@ravjot07
Copy link

Hi @ravjot07

Thanks very much, and we can move forward with this part of the work as planned. You can complete some necessary preparations through the paperwork solution. You can add some paperwork solution PRs to this directory: https://github.com/kcl-lang/kpm/tree/main/research/design-doc.

Sure @zong-zhe I will add paperwork solution for this issue as well......

ravjot07 added a commit to ravjot07/kpm that referenced this issue Dec 8, 2024
@ravjot07
Copy link

ravjot07 commented Dec 8, 2024

hey @zong-zhe ,

Can You review this Paperwork solution PR....

@SkySingh04
Copy link

This sounds very interesting, I will also be submitting a Paperwork solution for this! So much to learn here!

@SkySingh04
Copy link

Hey @zong-zhe , do you mind taking a look at my proposed solution as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants