-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LFX] LSP quick fix for kcl compiler #997
Comments
Hi! I would like to work on this issue under the upcoming LFX term. Are there any related issues to the same, which I can parse through or try to solve as pre-tasks for the same? |
Sorry, I didn't understand what you meant 'Are there ant related issues to the same'? You can learn about LSP, https://code.visualstudio.com/api/language-extensions/overview Finally, You can try to set up a development environment (Rust & LLVM), build an LSP binary locally and install the KCL extension(https://marketplace.visualstudio.com/items?itemName=kcl.kcl-vscode-extension) to experience it. |
Hi @He1pa! Thanks for the detailed response. Since this is an LFX issue, I thought the same would be frozen for contributors until the mentees are officially announced, and thus, I asked for any other related child issues, sort of qualifying tasks for the term. |
Do you want me to provide a pretest to determine candidates? I will provide a new issue as soon as possible, this issue is to solve a smaller but related problem |
hey @He1pa , I would like to work on this |
Hey @He1pa, can you please shed some light on the scope of this project ? Specifically, which types of errors or warnings are expected to be quick fixed ? Does the project cover every error possible ? Thanks in advance. I have prior experience in building custom linters and custom fixes for errors. Please look at this issue where I created a documentation checking linter from scratch for the Dart/Flutter codebase, and this PR where I implemented quick fixes for the same. Excited to work on this project. |
Dup with #1125 |
Provide quick fix capability with LSP for kcl compiler
How to apply
Pretest
To apply for this mentorship, you MUST finish a pre-test. Pre-test link: #1020
Detail
That is, provide
suggested_replacement
in the structure below. Now, this field is almost entirelyNone
This field will be processed as a CodeAction response in the LSP, and provide quick fix capability in editor.
Appendix
LSP Overview:
LSP spec:
quick fix impl pr:
The text was updated successfully, but these errors were encountered: