Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use qrcode-generator as package dependency? #30

Open
sabrinaluo opened this issue Jul 13, 2018 · 1 comment
Open

use qrcode-generator as package dependency? #30

sabrinaluo opened this issue Jul 13, 2018 · 1 comment

Comments

@sabrinaluo
Copy link

sabrinaluo commented Jul 13, 2018 •
edited
Loading

Hello, thank you for the amazing qart.

Wondering if it's possible to use https://www.npmjs.com/package/qrcode-generator as dependency rather than including qrcode.js in the bundle? or maybe expose qrcode API ?

The situation I encountered is to need both API of qart and qrcode, since qart didn't expose the qrcode API, will need to install the origin qrcode-generator. This makes the bundle size bigger than it should. :)
@misteral
Copy link
Collaborator

misteral commented Jul 15, 2018 •
edited
Loading

@sabrinaluo Hi, please welcome pull request. @kciter what u think(do we have any changes in local version) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@misteral @sabrinaluo