Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column_count by device or screen size? #18

Open
sjabby opened this issue May 16, 2021 · 5 comments
Open

column_count by device or screen size? #18

sjabby opened this issue May 16, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@sjabby
Copy link

sjabby commented May 16, 2021

Is it possible to add a parameter to set column_count by device (ie mobile) or screen size to have the site be more responsive?

@kc0bfv
Copy link
Owner

kc0bfv commented May 17, 2021

The default was two columns, which worked pretty well at a lot of device sizes. Unfortunately, to have the columns show up as columns (instead of something like a flexbox row) the photos are laid out at build time. To do something like variable-column-count based on device width, in CSS, would require a different layout that wouldn't produce the nice columns. Or it could maybe get built at runtime with JS... Or it could just reflow columns to show up at the bottom below the first columns...

I think the first one isn't what this theme is going for. The second would be a lot of JS for little gain. The third is a bit of a hack but might be a good option. I'll keep thinking about this one - the original purpose was definitely just to use 2 columns though. Maybe I should just mention this tradeoff in the readme.

@sjabby
Copy link
Author

sjabby commented May 17, 2021

Thanks for the feedback. I think with some adjustments to columns etc this theme would also work very well with portrait photos.

@vicevolf
Copy link

On the contrary, if I browse the website with 4K monitor, the thumbnail will be stretched and blurred. Maybe max-width: 1200px will help?

@kc0bfv
Copy link
Owner

kc0bfv commented Mar 6, 2022

@volfclub I think you're right. I've temporarily set a max-width in the "cur_ver_release" branch. I don't love the way that looks, so might change it a little still.

I also think I'm gonna have to go the Javascript route to solve the underlying problem in an all-around acceptable way. Just not taking the time yet to do it. The tradeoffs there are - it's probably possible to meet every requirement except the "low javascript" one. I'll probably screw up some accessibility type things along the way too, although this theme isn't great with that anyway...

@kc0bfv
Copy link
Owner

kc0bfv commented May 23, 2022

I merged the max-width into main now, I haven't taken the time to do the better javascript fix yet....

@kc0bfv kc0bfv added the enhancement New feature or request label May 23, 2022
@kc0bfv kc0bfv self-assigned this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants