Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export newFDLoggerSet #75

Open
ocharles opened this issue Jan 19, 2016 · 5 comments
Open

Export newFDLoggerSet #75

ocharles opened this issue Jan 19, 2016 · 5 comments

Comments

@ocharles
Copy link

Is there any reason to have this private?

@kazu-yamamoto
Copy link
Owner

It depends on FD. I don't know that it is a good thing to export FD or not.

@ocharles
Copy link
Author

In fact, I'd say just export LoggerSet. Right now I just wanted to create my own, but I'm completely stuck.

@kazu-yamamoto
Copy link
Owner

I'm OK to create the Internal module and export something in it. Is LoggerSet(..) enough for you?

@ocharles
Copy link
Author

Sounds good, it might be worth putting LogStr in there too. I don't think there is really much benefit preventing people constructing these by hand if they so desire too (but keeping the constructors out of the main documentation sounds good).

@kazu-yamamoto
Copy link
Owner

If you want to create System.Log.FastLogger.Internal by yourself, please do it and send me a pull request. If not, it will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants