Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ABNF supported? #57

Closed
xcurry opened this issue Dec 14, 2021 · 3 comments
Closed

Is ABNF supported? #57

xcurry opened this issue Dec 14, 2021 · 3 comments

Comments

@xcurry
Copy link

xcurry commented Dec 14, 2021

I downloaded and built kgt and then ran this command:

./build/bin/kgt -l abnf -e svg < ./examples/abnf.abnf > ./abnf.svg

No message and the output length of file abnf.svg is 0. However, expr.bnf to expr.svg works fine. Have not tried other flavours yet.

@katef
Copy link
Owner

katef commented Dec 20, 2021

ABNF is supported! The parsing there is tripping up on the trailing comments after productions. That's a bug, #11. I'm not sure how to fix it.

Also not giving an error message is a bug.

If you remove the comments, you should see output:

; cat examples/abnf.abnf | grep -v ';' | ./build/bin/kgt -l abnf -e svg

@xcurry
Copy link
Author

xcurry commented Dec 20, 2021

Will close this as it is already being tracked. The workaround is what I will use in the meantime.

@xcurry xcurry closed this as completed Dec 20, 2021
@katef
Copy link
Owner

katef commented Dec 23, 2021

Thanks for reporting it! sorry it sucks a bit. I think I have to rework how all the whitespace is handled for ABNF, somehow. I'm really not sure :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants