Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change OpenMapSurfer_Roads basemap to terrain #33

Closed
wants to merge 1 commit into from
Closed

change OpenMapSurfer_Roads basemap to terrain #33

wants to merge 1 commit into from

Conversation

boney-bun
Copy link
Contributor

@boney-bun boney-bun requested a review from lucernae March 26, 2019 07:41
@ghost ghost assigned boney-bun Mar 26, 2019
@ghost ghost added the in progress label Mar 26, 2019
lucernae
lucernae requested changes Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@lucernae lucernae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boney-bun I believe you are changing too much in the skin just to change the basemap.
If GeoSAFE code changes, your code will break.
Modify the necessary base code in GeoSAFE first, then customize the basemap in this skin app via default settings.py

@boney-bun
Copy link
Contributor Author

thanks @lucernae

i'm going to close this PR.
the necessary changes are now in kartoza/geonode#545

@boney-bun boney-bun closed this Mar 26, 2019
@ghost ghost removed the in progress label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucernae lucernae lucernae requested changes

Assignees

@boney-bun boney-bun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove MapSurfer and change default basemap
2 participants
@boney-bun @lucernae