Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxon validation #4227

Open
helendallas opened this issue Sep 6, 2024 · 9 comments
Open

Taxon validation #4227

helendallas opened this issue Sep 6, 2024 · 9 comments

Comments

@helendallas
Copy link
Collaborator

helendallas commented Sep 6, 2024

If the Group contributor (Plecoptera - South Africa) validates a new taxon, then the Group Coordinator (Plecoptera - Global) gets an email, saying the taxon has been validated by Plecoptera-South Africa, it now requires validation to the taxon group Plecoptera- Global.

BUT, the taxon is already validated at the Global level. It should not be automatically validated when the Group Contributor validates the taxon. There needs to be a second step whereby the Group Coordinator validates it for the Global Group. The email should also be updated to say Plecoptera -Global i.e. the Group coordinator level. At the moment it is Plecoptera-South Africa.

Initial validation
Screenshot 2024-09-06 at 11 09 49

At Group coordinator, the taxon is unvalidated (filter=unvalidation), but there is not way for the Group Coordinator to validate - the Approve, Reject option is not visible.

Screenshot 2024-09-06 at 11 10 34
@helendallas
Copy link
Collaborator Author

please see #3644 . We have only just picked up issue whereby validation is not working correctly.

@dimasciput dimasciput added the SIZE 2 Give me 2 hours and I will have it for you label Sep 9, 2024
@dimasciput dimasciput added SIZE 3 and removed SIZE 2 Give me 2 hours and I will have it for you labels Sep 9, 2024
@dimasciput
Copy link
Member

@helendallas I have fixed this on staging

@helendallas
Copy link
Collaborator Author

@dimasciput I don't think this is sorted yet.

I am the expert in Plecoptera - South Africa.
I added a new taxon, but didn't get a validation noticed.

So I decided to validate it - and now the taxon is added to Plecoptera - Global but is not added to Plecoptera- South Africa, and no email received.

Please check workflows and emails again.

It should be:

User adds new taxon to Plecoptera- SA
Plecoptera - SA expert - gets email, checks taxon and validates or reject.
New taxon is then added to Plecoptera- SA

Then Plecoptera - Globel expert gets email saying Plecoptera - SA has validated a new taxon,
then Plecoptera- Global expert has option to Validate or reject.
If validated New taxon is added to Plecoptera - Global

@helendallas
Copy link
Collaborator Author

helendallas commented Sep 10, 2024

So the above was when I added a synonym from GBIF. let me try again with a taxon not on gbif.

Okay so Pleacoptera-global expert is still not receiving the unvalidated taxon. it is validated automatically when the Plecoptera-SA expert validates it.

@schmikloi wants there the be a second level of validation that the global expert = data coordinator does

@dimasciput
Copy link
Member

hi @helendallas

Ah, I got the emails, so it's probably just a bug. That's why you're not receiving them. I'll fix it later.

User adds new taxon to Plecoptera- SA
Plecoptera - SA expert - gets email, checks taxon and validates or reject.
New taxon is then added to Plecoptera- SA

The logic that has been implemented is actually quite different from what you're describing. I believe we've discussed this before, but making changes to this might take some time.

Currently, when a taxon is added to a child taxon group, it isn't automatically added to the parent taxon group.

For example, in a Parent → Child relationship, if a user adds a new taxon to the child group, it will only belong to the child taxon group, even if it is validated. The parent taxon group doesn't include this taxon, it simply checks whether the taxon in the child group has been validated.

What you're asking for is that when a new taxon is added to the child taxon group, it should also be added to the parent group, correct?

This is what we have at the moment

image

I think this is what you want?

image

There are some challenges with second approach. For instance, if a user rejects the taxon in the parent group but it's still validated in the child group, what happens to the taxon then? We would need to introduce a workflow for the user to propose it again, which adds complexity. The current process is simpler and more straightforward—if a taxon is rejected, it’s rejected across all groups.

There's also some issues when user move the taxon group to other parent.

Could you discuss this with Astrid first?
Let me fix the email issues for now.

@helendallas
Copy link
Collaborator Author

Okay let me discuss with Astrid

@helendallas
Copy link
Collaborator Author

Thanks @dimasciput This seems to be working now.

@schmikloi
Copy link
Collaborator

Okay let me discuss with Astrid

Hi @helendallas
Should we discuss this in a short Zoom?
I mean it was part of the requirements to have multiple levels of data entry, but it does not necessarily have to be connected with a regional-level taxagroup.
The main point here is that someone who is not the highest level expert can suggest a new species (independently from any regional scale/taxalist) and the highest level expert then agrees or disagrees to add this species to the global list.

@helendallas
Copy link
Collaborator Author

It seems @dimasciput has added this already. perhaps test the system and see that you are happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🌄 Done
Development

No branches or pull requests

3 participants