-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxon validation #4227
Comments
please see #3644 . We have only just picked up issue whereby validation is not working correctly. |
@helendallas I have fixed this on staging |
@dimasciput I don't think this is sorted yet. I am the expert in Plecoptera - South Africa. So I decided to validate it - and now the taxon is added to Plecoptera - Global but is not added to Plecoptera- South Africa, and no email received. Please check workflows and emails again. It should be: User adds new taxon to Plecoptera- SA Then Plecoptera - Globel expert gets email saying Plecoptera - SA has validated a new taxon, |
So the above was when I added a synonym from GBIF. let me try again with a taxon not on gbif. Okay so Pleacoptera-global expert is still not receiving the unvalidated taxon. it is validated automatically when the Plecoptera-SA expert validates it. @schmikloi wants there the be a second level of validation that the global expert = data coordinator does |
hi @helendallas Ah, I got the emails, so it's probably just a bug. That's why you're not receiving them. I'll fix it later.
The logic that has been implemented is actually quite different from what you're describing. I believe we've discussed this before, but making changes to this might take some time. Currently, when a taxon is added to a child taxon group, it isn't automatically added to the parent taxon group. For example, in a Parent → Child relationship, if a user adds a new taxon to the child group, it will only belong to the child taxon group, even if it is validated. The parent taxon group doesn't include this taxon, it simply checks whether the taxon in the child group has been validated. What you're asking for is that when a new taxon is added to the child taxon group, it should also be added to the parent group, correct? This is what we have at the moment I think this is what you want? There are some challenges with second approach. For instance, if a user rejects the taxon in the parent group but it's still validated in the child group, what happens to the taxon then? We would need to introduce a workflow for the user to propose it again, which adds complexity. The current process is simpler and more straightforward—if a taxon is rejected, it’s rejected across all groups. There's also some issues when user move the taxon group to other parent. Could you discuss this with Astrid first? |
Okay let me discuss with Astrid |
Thanks @dimasciput This seems to be working now. |
Hi @helendallas |
It seems @dimasciput has added this already. perhaps test the system and see that you are happy |
If the Group contributor (Plecoptera - South Africa) validates a new taxon, then the Group Coordinator (Plecoptera - Global) gets an email, saying the taxon has been validated by Plecoptera-South Africa, it now requires validation to the taxon group Plecoptera- Global.
BUT, the taxon is already validated at the Global level. It should not be automatically validated when the Group Contributor validates the taxon. There needs to be a second step whereby the Group Coordinator validates it for the Global Group. The email should also be updated to say Plecoptera -Global i.e. the Group coordinator level. At the moment it is Plecoptera-South Africa.
Initial validation
At Group coordinator, the taxon is unvalidated (filter=unvalidation), but there is not way for the Group Coordinator to validate - the Approve, Reject option is not visible.
The text was updated successfully, but these errors were encountered: