Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite recursion on symbolic link loops, README incorrect? #64

Open
enricozb opened this issue May 18, 2021 · 0 comments
Open

Infinite recursion on symbolic link loops, README incorrect? #64

enricozb opened this issue May 18, 2021 · 0 comments

Comments

@enricozb
Copy link

The README says the following:

This library fixes the above problem such that it will never follow logical file sytem [sic] loops on either unix or Windows.

I think this is false. I have a directory structure like the following:

walk-links/
└── loop
    └── loop-link-upwards -> ../../walk-links/

When calling godirwalk.Walk on walk-links, it descends infinitely when FollowSymbolicLinks is set to true. I know that this is an adversarial example, but unless godirwalk is somehow keeping track of all paths that have been visited, I don't think the README is accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant