Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer bigram model? #5

Open
eniompw opened this issue Jan 24, 2023 · 1 comment
Open

no longer bigram model? #5

eniompw opened this issue Jan 24, 2023 · 1 comment

Comments

@eniompw
Copy link

eniompw commented Jan 24, 2023 •
edited
Loading

In https://github.com/karpathy/ng-video-lecture/blob/master/gpt.py
on lines 136 / 137:

# super simple bigram model
class BigramLanguageModel(nn.Module):

just to clarify, is this now a GPT model and not a bigram model?
@eniompw eniompw changed the title bigram model? no longer bigram model? Jan 24, 2023
@theicfire
Copy link

Yeah, looks fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theicfire @eniompw